Fix a problem where builds were failing due to an API break in @types/webpack

octogonz · octogonz · commit aef291327a15 · 2019-11-19T20:13:35.000-08:00
diff --git a/core-build/gulp-core-build-webpack/package.json b/core-build/gulp-core-build-webpack/package.json
@@ -27,7 +27,7 @@
     "@types/orchestrator": "0.0.30",
     "@types/source-map": "0.5.0",
     "@types/uglify-js": "2.6.29",
-    "@types/webpack": "^4.0.0",
+    "@types/webpack": "4.39.8",
     "@types/webpack-dev-server": "3.1.7"
   }
 }
diff --git a/webpack/loader-load-themed-styles/package.json b/webpack/loader-load-themed-styles/package.json
@@ -23,7 +23,7 @@
     "@types/loader-utils": "1.1.3",
     "@types/mocha": "5.2.5",
     "@types/node": "8.10.54",
-    "@types/webpack": "^4.0.0",
+    "@types/webpack": "4.39.8",
     "chai": "~3.5.0",
     "gulp": "~4.0.2"
   }
diff --git a/webpack/resolve-chunk-plugin/package.json b/webpack/resolve-chunk-plugin/package.json
@@ -12,15 +12,13 @@
   "scripts": {
     "build": "gulp test --clean"
   },
-  "dependencies": {
-    "@types/webpack": "^4.0.0"
-  },
   "devDependencies": {
     "@microsoft/node-library-build": "6.3.7",
     "@microsoft/rush-stack-compiler-3.4": "0.3.7",
     "@rushstack/eslint-config": "0.4.2",
     "@types/mocha": "5.2.5",
     "@types/node": "8.10.54",
+    "@types/webpack": "4.39.8",
     "chai": "~3.5.0",
     "gulp": "~4.0.2",
     "mocha": "^5.2.0"
diff --git a/webpack/set-webpack-public-path-plugin/package.json b/webpack/set-webpack-public-path-plugin/package.json
@@ -13,7 +13,6 @@
     "build": "gulp test --clean"
   },
   "dependencies": {
-    "@types/webpack": "^4.0.0",
     "lodash": "~4.17.15",
     "uglify-js": "~3.0.28"
   },
@@ -26,6 +25,7 @@
     "@types/node": "8.10.54",
     "@types/tapable": "1.0.4",
     "@types/uglify-js": "2.6.29",
+    "@types/webpack": "4.39.8",
     "chai": "~3.5.0",
     "gulp": "~4.0.2",
     "mocha": "^5.2.0"

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`"@types/orchestrator": "0.0.30",`
`28`	`28`	`"@types/source-map": "0.5.0",`
`29`	`29`	`"@types/uglify-js": "2.6.29",`
`30`		`- "@types/webpack": "^4.0.0",`
	`30`	`+ "@types/webpack": "4.39.8",`
`31`	`31`	`"@types/webpack-dev-server": "3.1.7"`
`32`	`32`	`}`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`"@types/loader-utils": "1.1.3",`
`24`	`24`	`"@types/mocha": "5.2.5",`
`25`	`25`	`"@types/node": "8.10.54",`
`26`		`- "@types/webpack": "^4.0.0",`
	`26`	`+ "@types/webpack": "4.39.8",`
`27`	`27`	`"chai": "~3.5.0",`
`28`	`28`	`"gulp": "~4.0.2"`
`29`	`29`	`}`