treat types as an alias for typings in package.json

Rudolf Meijering · Rudolf Meijering · commit 8c0e3c42683f · 2019-02-26T22:00:52.000+01:00
According to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html `types` is an alias for `typings`. This commit updates api-extractor to infer configuration from both of these properties.
diff --git a/apps/api-extractor/bin/api-extractor b/apps/api-extractor/bin/api-extractor
diff --git a/common/reviews/api/node-core-library.api.ts b/common/reviews/api/node-core-library.api.ts
@@ -269,6 +269,7 @@ interface IPackageJson {
     tsdoc?: IPackageJsonTsdocConfiguration;
     // @beta
     tsdocMetadata?: string;
+    types?: string;
     typings?: string;
     version: string;
 }
diff --git a/libraries/node-core-library/src/IPackageJson.ts b/libraries/node-core-library/src/IPackageJson.ts
@@ -95,6 +95,11 @@ export interface IPackageJson {
    * The path to the TypeScript *.d.ts file describing the module file
    * that will act as the main entry point.
    */
+  types?: string;
+
+  /**
+   * Alias for `types`
+   */
   typings?: string;
 
   /**
diff --git a/libraries/node-core-library/src/PackageJsonLookup.ts b/libraries/node-core-library/src/PackageJsonLookup.ts
@@ -224,7 +224,7 @@ export class PackageJsonLookup {
         packageJson.peerDependencies = loadedPackageJson.peerDependencies;
         packageJson.private = loadedPackageJson.private;
         packageJson.scripts = loadedPackageJson.scripts;
-        packageJson.typings = loadedPackageJson.typings;
+        packageJson.typings = loadedPackageJson.typings || loadedPackageJson.types;
         packageJson.tsdoc = loadedPackageJson.tsdoc;
         packageJson.tsdocMetadata = loadedPackageJson.tsdocMetadata;
         packageJson.version = loadedPackageJson.version;

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,7 @@ interface IPackageJson {`
`269`	`269`	`tsdoc?: IPackageJsonTsdocConfiguration;`
`270`	`270`	`// @beta`
`271`	`271`	`tsdocMetadata?: string;`
	`272`	`+ types?: string;`
`272`	`273`	`typings?: string;`
`273`	`274`	`version: string;`
`274`	`275`	`}`