Add an additional build configuration which will treat warnings as if they are errors

nickpape-msft · nickpape-msft · commit 8b2be8fa5ad3 · 2016-10-25T12:09:00.000-07:00
diff --git a/common/npm-local/package.json b/common/npm-local/package.json
@@ -0,0 +1,9 @@
+{
+  "dependencies": {
+    "npm": "3.10.8"
+  },
+  "description": "Temporary file generated by the NPMX tool",
+  "name": "local-npm-install",
+  "private": true,
+  "version": "0.0.0"
+}
diff --git a/gulp-core-build/src/IBuildConfig.ts b/gulp-core-build/src/IBuildConfig.ts
@@ -49,6 +49,9 @@ export interface IBuildConfig {
   /** Build a full production build. */
   production?: boolean;
 
+  /** Show warnings as errors (write them in red vs yellow to stderr, and fail the build) */
+  showWarningsAsErrors?: boolean;
+
   /** Arguments passed in. */
   args?: { [name: string]: string | boolean };
 
diff --git a/gulp-core-build/src/logging.ts b/gulp-core-build/src/logging.ts
@@ -8,6 +8,7 @@ const prettyTime = require('pretty-hrtime');
 /* tslint:enable:typedef */
 import * as state from './State';
 import { getFlagValue } from './config';
+import { getConfig } from './index';
 
 const WROTE_ERROR_KEY: string = '__gulpCoreBuildWroteError';
 
@@ -54,7 +55,7 @@ let globalInstance: any = global as any;
 const localCache: ILocalCache = globalInstance.__loggingCache = globalInstance.__loggingCache || {
   warnings: [],
   errors: [],
-  testsRun: 0,
+  testsRun: 0,;
   subTasksRun: 0,
   testsPassed: 0,
   testsFailed: 0,
@@ -442,8 +443,13 @@ export function warn(...args: Array<string | Chalk.ChalkChain>): void {
   const stringMessage: string = args.join(' ');
 
   if (!localCache.errorAndWarningSupressions[stringMessage]) {
-    localCache.warnings.push(stringMessage);
-    log(gutil.colors.yellow.apply(undefined, args));
+    if (getConfig().showWarningsAsErrors) {
+      localCache.errors.push(stringMessage);
+      log(gutil.colors.red.apply(undefined, args));
+    } else {
+      localCache.warnings.push(stringMessage);
+      log(gutil.colors.yellow.apply(undefined, args));
+    }
   }
 }
 
