singletons and collidingNames did not need to be optional parameters

octogonz · octogonz · commit 3f00dbfbe839 · 2019-09-23T23:10:41.000-07:00
diff --git a/apps/api-documenter/src/documenters/YamlDocumenter.ts b/apps/api-documenter/src/documenters/YamlDocumenter.ts
@@ -624,26 +624,24 @@ export class YamlDocumenter {
 
   private _trackCollisionsWithSiblings(
     apiItem: ApiItem,
-    singletons?: Map<string, ApiItem>,
-    collidingNames?: Set<string>
+    singletons: Map<string, ApiItem>,
+    collidingNames: Set<string>
   ): void {
-    if (singletons && collidingNames) {
-      if (!collidingNames.has(apiItem.displayName)) {
-        const collision: ApiItem | undefined = singletons.get(apiItem.displayName);
-        if (!collision) {
-          // No collision. Record this singleton entry.
-          singletons.set(apiItem.displayName, apiItem);
-          return;
-        }
-        // First collision. Record the colliding name.
-        collidingNames.add(apiItem.displayName);
-        singletons.delete(apiItem.displayName);
-        // Record the initial entry.
-        this._collisions.add(collision);
-      }
-      // Record the colliding entry.
-      this._collisions.add(apiItem);
-    }
+    if (!collidingNames.has(apiItem.displayName)) {
+      const collision: ApiItem | undefined = singletons.get(apiItem.displayName);
+      if (!collision) {
+        // No collision. Record this singleton entry.
+        singletons.set(apiItem.displayName, apiItem);
+        return;
+      }
+      // First collision. Record the colliding name.
+      collidingNames.add(apiItem.displayName);
+      singletons.delete(apiItem.displayName);
+      // Record the initial entry.
+      this._collisions.add(collision);
+    }
+    // Record the colliding entry.
+    this._collisions.add(apiItem);
   }
 
   private _ensureYamlReferences(): IYamlReferences {
