Update some code to use a guaranteed stable sort

octogonz · octogonz · commit 37f834fd63db · 2019-11-02T13:24:59.000-07:00
diff --git a/apps/api-extractor-model/src/mixins/ApiItemContainerMixin.ts b/apps/api-extractor-model/src/mixins/ApiItemContainerMixin.ts
@@ -11,7 +11,7 @@ import {
 } from '../items/ApiItem';
 import { ApiNameMixin } from './ApiNameMixin';
 import { DeserializerContext } from '../model/DeserializerContext';
-import { InternalError } from '@microsoft/node-core-library';
+import { InternalError, LegacyAdapters } from '@microsoft/node-core-library';
 
 /**
  * Constructor options for {@link (ApiItemContainerMixin:interface)}.
@@ -145,7 +145,7 @@ export function ApiItemContainerMixin<TBaseClass extends IApiItemConstructor>(ba
 
     public get members(): ReadonlyArray<ApiItem> {
       if (!this[_membersSorted]) {
-        this[_members].sort((x, y) => x.getSortKey().localeCompare(y.getSortKey()));
+        LegacyAdapters.sortStable(this[_members], (x, y) => x.getSortKey().localeCompare(y.getSortKey()));
         this[_membersSorted] = true;
       }
 
diff --git a/apps/api-extractor/src/collector/MessageRouter.ts b/apps/api-extractor/src/collector/MessageRouter.ts
@@ -4,7 +4,7 @@
 import * as colors from 'colors';
 import * as ts from 'typescript';
 import * as tsdoc from '@microsoft/tsdoc';
-import { Sort, InternalError } from '@microsoft/node-core-library';
+import { Sort, InternalError, LegacyAdapters } from '@microsoft/node-core-library';
 import { AedocDefinitions } from '@microsoft/api-extractor-model';
 
 import { TypeScriptMessageFormatter } from '../analyzer/TypeScriptMessageFormatter';
@@ -563,7 +563,7 @@ export class MessageRouter {
    * Sorts an array of messages according to a reasonable ordering
    */
   private _sortMessagesForOutput(messages: ExtractorMessage[]): void {
-    messages.sort((a, b) => {
+    LegacyAdapters.sortStable(messages, (a, b) => {
       let diff: number;
       // First sort by file name
       diff = Sort.compareByValue(a.sourceFilePath, b.sourceFilePath);
diff --git a/apps/rush-lib/src/logic/taskRunner/TaskCollection.ts b/apps/rush-lib/src/logic/taskRunner/TaskCollection.ts
@@ -3,7 +3,8 @@
 
 import {
   Terminal,
-  ConsoleTerminalProvider
+  ConsoleTerminalProvider,
+  Sort
 } from '@microsoft/node-core-library';
 
 import { ITask, ITaskDefinition } from './ITask';
@@ -105,9 +106,7 @@ export class TaskCollection {
     });
 
     // Sort the queue in descending order, nothing will mess with the order
-    buildQueue.sort((taskA: ITask, taskB: ITask): number => {
-      return taskB.criticalPathLength! - taskA.criticalPathLength!;
-    });
+    Sort.sortBy(buildQueue, (task: ITask): number => -task.criticalPathLength!);
 
     return buildQueue;
   }
