Fix ESLint issues for ts-command-line

octogonz · octogonz · commit 1e6d2e961404 · 2019-10-21T00:20:08.000-07:00
diff --git a/libraries/ts-command-line/.eslintrc.js b/libraries/ts-command-line/.eslintrc.js
@@ -0,0 +1,7 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require("@rushstack/eslint-config/patch-eslint6");
+
+module.exports = {
+  extends: [ "@rushstack/eslint-config" ],
+  parserOptions: { tsconfigRootDir: __dirname },
+};
diff --git a/libraries/ts-command-line/src/CommandLineAction.ts b/libraries/ts-command-line/src/CommandLineAction.ts
@@ -56,7 +56,7 @@ export abstract class CommandLineAction extends CommandLineParameterProvider {
 
   private _argumentParser: argparse.ArgumentParser | undefined;
 
-  constructor(options: ICommandLineActionOptions) {
+  public constructor(options: ICommandLineActionOptions) {
     super();
 
     if (!CommandLineAction._actionNameRegExp.test(options.actionName)) {
diff --git a/libraries/ts-command-line/src/CommandLineParameter.ts b/libraries/ts-command-line/src/CommandLineParameter.ts
@@ -67,7 +67,7 @@ export abstract class CommandLineParameter {
   public readonly environmentVariable: string | undefined;
 
   /** @internal */
-  constructor(definition: IBaseCommandLineDefinition) {
+  public constructor(definition: IBaseCommandLineDefinition) {
     this.longName = definition.parameterLongName;
     this.shortName = definition.parameterShortName;
     this.description = definition.description;
@@ -173,7 +173,7 @@ export abstract class CommandLineParameterWithArgument extends CommandLineParame
   public readonly argumentName: string;
 
   /** @internal */
-  constructor(definition: IBaseCommandLineDefinitionWithArgument) {
+  public constructor(definition: IBaseCommandLineDefinitionWithArgument) {
     super(definition);
 
     if (definition.argumentName === '') {
@@ -206,7 +206,7 @@ export class CommandLineChoiceParameter extends CommandLineParameter {
   private _value: string | undefined = undefined;
 
   /** @internal */
-  constructor(definition: ICommandLineChoiceDefinition) {
+  public constructor(definition: ICommandLineChoiceDefinition) {
     super(definition);
 
     if (definition.alternatives.length < 1) {
@@ -302,7 +302,7 @@ export class CommandLineFlagParameter extends CommandLineParameter {
   private _value: boolean = false;
 
   /** @internal */
-  constructor(definition: ICommandLineFlagDefinition) {
+  public constructor(definition: ICommandLineFlagDefinition) {
     super(definition);
   }
 
@@ -371,7 +371,7 @@ export class CommandLineIntegerParameter extends CommandLineParameterWithArgumen
   private _value: number | undefined = undefined;
 
   /** @internal */
-  constructor(definition: ICommandLineIntegerDefinition) {
+  public constructor(definition: ICommandLineIntegerDefinition) {
     super(definition);
     this.defaultValue = definition.defaultValue;
     this.validateDefaultValue(!!this.defaultValue);
@@ -460,7 +460,7 @@ export class CommandLineStringParameter extends CommandLineParameterWithArgument
   private _value: string | undefined = undefined;
 
   /** @internal */
-  constructor(definition: ICommandLineStringDefinition) {
+  public constructor(definition: ICommandLineStringDefinition) {
     super(definition);
 
     this.defaultValue = definition.defaultValue;
@@ -547,7 +547,7 @@ export class CommandLineStringListParameter extends CommandLineParameterWithArgu
   private _values: string[] = [];
 
   /** @internal */
-  constructor(definition: ICommandLineStringListDefinition) {
+  public constructor(definition: ICommandLineStringListDefinition) {
     super(definition);
   }
 
diff --git a/libraries/ts-command-line/src/CommandLineParameterProvider.ts b/libraries/ts-command-line/src/CommandLineParameterProvider.ts
@@ -44,7 +44,7 @@ export abstract class CommandLineParameterProvider {
 
   /** @internal */
   // Third party code should not inherit subclasses or call this constructor
-  constructor() {
+  public constructor() {
     this._parameters = [];
     this._parametersByLongName = new Map<string, CommandLineParameter>();
   }
diff --git a/libraries/ts-command-line/src/CommandLineParser.ts b/libraries/ts-command-line/src/CommandLineParser.ts
@@ -26,7 +26,7 @@ export interface ICommandLineParserOptions {
 export class CommandLineParserExitError extends Error {
   public readonly exitCode: number;
 
-  constructor(exitCode: number, message: string) {
+  public constructor(exitCode: number, message: string) {
     super(message);
 
     // Manually set the prototype, as we can no longer extend built-in classes like Error, Array, Map, etc
@@ -86,7 +86,7 @@ export abstract class CommandLineParser extends CommandLineParameterProvider {
   private _actionsByName: Map<string, CommandLineAction>;
   private _executed: boolean = false;
 
-  constructor(options: ICommandLineParserOptions) {
+  public constructor(options: ICommandLineParserOptions) {
     super();
 
     this._options = options;
diff --git a/libraries/ts-command-line/tslint.json b/libraries/ts-command-line/tslint.json

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export abstract class CommandLineParameterProvider {`
`44`	`44`
`45`	`45`	`/** @internal */`
`46`	`46`	`// Third party code should not inherit subclasses or call this constructor`
`47`		`- constructor() {`
	`47`	`+ public constructor() {`
`48`	`48`	`this._parameters = [];`
`49`	`49`	`this._parametersByLongName = new Map<string, CommandLineParameter>();`
`50`	`50`	`}`