Fix an issue where DocItem.getApiReference() produced an invalid IApiItemReference

pgonzal · pgonzal · commit 1927baee0b86 · 2018-03-31T00:45:53.000-07:00
diff --git a/apps/api-documenter/src/utils/DocItemSet.ts b/apps/api-documenter/src/utils/DocItemSet.ts
@@ -132,7 +132,8 @@ export class DocItem {
     for (const docItem of this.getHierarchy()) {
       switch (i) {
         case 0:
-          reference.packageName = docItem.name;
+          reference.scopeName = PackageName.getScope(docItem.name);
+          reference.packageName = PackageName.getUnscopedName(docItem.name);
           break;
         case 1:
           reference.exportName = docItem.name;
diff --git a/apps/api-extractor/src/markup/Markup.ts b/apps/api-extractor/src/markup/Markup.ts
@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
+import { PackageName } from '@microsoft/node-core-library';
 import {
   MarkupElement,
   MarkupBasicElement,
@@ -131,6 +132,9 @@ export class Markup {
       throw new Error('The IApiItemReference.packageName cannot be empty');
     }
 
+    // Validate that the scopeName and packageName are formatted correctly
+    PackageName.combineParts(target.scopeName, target.packageName);
+
     return {
       kind: 'api-link',
       elements: textElements,
