Skip to content

Commit ecdc72b

Browse files
brockallenbrockallen
committed
don't require signing keys to have "use"
1 parent 1c64e32 commit ecdc72b

File tree

7 files changed

+34
-86
lines changed

7 files changed

+34
-86
lines changed

‎dist/oidc-client.js‎

Lines changed: 13 additions & 20 deletions
Large diffs are not rendered by default.

‎dist/oidc-client.min.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/oidc-client.js‎

Lines changed: 13 additions & 20 deletions
Large diffs are not rendered by default.

‎lib/oidc-client.min.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "oidc-client",
3-
"version": "1.3.0-beta.2",
3+
"version": "1.3.0-beta.3",
44
"description": "OpenID Connect (OIDC) & OAuth2 client library",
55
"main": "lib/oidc-client.min.js",
66
"scripts": {

‎src/MetadataService.js‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -136,20 +136,9 @@ export default class MetadataService {
136136
throw new Error("Missing keys on keyset");
137137
}
138138

139-
var filteredKeys = this._filterSigningKeys(keySet.keys);
140-
Log.debug("filtered keys", filteredKeys);
141-
142-
this._settings.signingKeys = filteredKeys;
139+
this._settings.signingKeys = keySet.keys;
143140
return this._settings.signingKeys;
144141
});
145142
});
146143
}
147-
148-
_filterSigningKeys(keys) {
149-
Log.debug("MetadataService._filterSigningKeys", keys);
150-
151-
return keys.filter(item => {
152-
return item.use === "sig";
153-
});
154-
}
155144
}

‎test/unit/MetadataService.spec.js‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -381,32 +381,5 @@ describe("MetadataService", function() {
381381
})
382382
});
383383

384-
it("should filter signing keys", function(done) {
385-
settings.metadata = {
386-
jwks_uri: "http://sts/metadata/keys"
387-
};
388-
stubJsonService.result = Promise.resolve({
389-
keys:[
390-
{
391-
use:'sig',
392-
kid:"test"
393-
},
394-
{
395-
use:'enc',
396-
kid:"test"
397-
}]
398-
});
399-
400-
let p = subject.getSigningKeys();
401-
402-
p.then(keys => {
403-
keys.should.deep.equal([{
404-
use:'sig',
405-
kid:"test"
406-
}]);
407-
done();
408-
})
409-
});
410-
411384
});
412385
});

0 commit comments

Comments
 (0)