Added glamor css (vercel#38)

impronunciable · rauchg · commit e164074f8ee3 · 2016-10-21T09:39:20.000-07:00
* Added glamor css

* Using pseudoclasses instead of calling functions

* Updated readme using style instead of default import for css
diff --git a/Readme.md b/Readme.md
@@ -44,15 +44,15 @@ We use [glamor](https://github.com/threepointone/glamor) to provide a great buil
 
 ```jsx
 import React from 'react'
-import css from 'next/css'
+import { style } from 'next/css'
 
 export default () => (
   <div className={style}>
     Hello world
   </div>
 )
 
-const style = css({
+const style = style({
   main: {
     background: 'red',
     ':hover': {
diff --git a/bench/fixtures/basic/pages/css.js b/bench/fixtures/basic/pages/css.js
@@ -1,11 +1,11 @@
 import React, { Component } from 'react'
-import { StyleSheet, css } from 'next/css'
+import { style } from 'next/css'
 
 export default class CrazyCSS extends Component {
   spans () {
     const out = []
     for (let i = 0; i < 1000; i++) {
-      out.push(<span key={i} class={css(styles[`padding-${i}`])}>This is ${i}</span>)
+      out.push(<span key={i} class={spanStyles[`padding-${i}`]}>This is ${i}</span>)
     }
     return out
   }
@@ -17,7 +17,5 @@ export default class CrazyCSS extends Component {
 
 const spanStyles = {}
 for (let i = 0; i < 1000; i++) {
-  spanStyles[`padding-${i}`] = { padding: i }
+  spanStyles[`padding-${i}`] = style({ padding: i })
 }
-
-const styles = StyleSheet.create(spanStyles)
diff --git a/client/next.js b/client/next.js
@@ -1,13 +1,13 @@
 import { createElement } from 'react'
 import { render } from 'react-dom'
 import HeadManager from './head-manager'
-import { StyleSheet } from '../lib/css'
+import { rehydrate } from '../lib/css'
 import Router from '../lib/router'
 import DefaultApp from '../lib/app'
 import evalScript from '../lib/eval-script'
 
 const {
-  __NEXT_DATA__: { app, component, props, classNames, err }
+  __NEXT_DATA__: { app, component, props, ids, err }
 } = window
 
 const App = app ? evalScript(app).default : DefaultApp
@@ -19,5 +19,5 @@ const headManager = new HeadManager()
 const container = document.getElementById('__next')
 const appProps = { Component, props, router, headManager }
 
-StyleSheet.rehydrate(classNames)
+rehydrate(ids)
 render(createElement(App, appProps), container)
diff --git a/examples/basic-css/pages/index.js b/examples/basic-css/pages/index.js
@@ -1,21 +1,19 @@
 import React from 'react'
-import { css, StyleSheet } from 'next/css'
+import { style } from 'next/css'
 
 export default () => (
-  <div className={css(styles.main)}>
+  <div className={styles}>
     <p>Hello World</p>
   </div>
 )
 
-const styles = StyleSheet.create({
-  main: {
-    font: '15px Helvetica, Arial, sans-serif',
-    background: '#eee',
-    padding: '100px',
-    textAlign: 'center',
-    transition: '100ms ease-in background',
-    ':hover': {
-      background: '#ccc'
-    }
+const styles = style({
+  font: '15px Helvetica, Arial, sans-serif',
+  background: '#eee',
+  padding: '100px',
+  textAlign: 'center',
+  transition: '100ms ease-in background',
+  ':hover': {
+    background: '#ccc'
   }
 })
diff --git a/examples/nested-components/components/paragraph.js b/examples/nested-components/components/paragraph.js
@@ -1,13 +1,11 @@
 import React from 'react'
-import { css, StyleSheet } from 'next/css'
+import { style } from 'next/css'
 
 export default ({ children }) => (
-  <p className={css(styles.main)}>{children}</p>
+  <p className={styles}>{children}</p>
 )
 
-const styles = StyleSheet.create({
-  main: {
-    font: '13px Helvetica, Arial',
-    margin: '10px 0'
-  }
+const styles = style({
+  font: '13px Helvetica, Arial',
+  margin: '10px 0'
 })
diff --git a/examples/nested-components/components/post.js b/examples/nested-components/components/post.js
@@ -1,23 +1,21 @@
 import React from 'react'
-import { css, StyleSheet } from 'next/css'
+import { style } from 'next/css'
 
 export default ({ title, children }) => (
-  <div className={css(styles.main)}>
-    <h1 className={css(styles.title)}>{ title }</h1>
+  <div className={mainStyle}>
+    <h1 className={titleStyle}>{ title }</h1>
     { children }
   </div>
 )
 
-const styles = StyleSheet.create({
-  main: {
-    font: '15px Helvetica, Arial',
-    border: '1px solid #eee',
-    padding: '0 10px'
-  },
+const mainStyle = style({
+  font: '15px Helvetica, Arial',
+  border: '1px solid #eee',
+  padding: '0 10px'
+})
 
-  title: {
-    fontSize: '16px',
-    fontWeight: 'bold',
-    margin: '10px 0'
-  }
+const titleStyle = style({
+  fontSize: '16px',
+  fontWeight: 'bold',
+  margin: '10px 0'
 })
diff --git a/examples/nested-components/pages/index.js b/examples/nested-components/pages/index.js
@@ -1,10 +1,10 @@
 import React from 'react'
 import P from '../components/paragraph'
 import Post from '../components/post'
-import { css, StyleSheet } from 'next/css'
+import { style } from 'next/css'
 
 export default () => (
-  <div className={css(styles.main)}>
+  <div className={styles.main}>
     <Post title='My first blog post'>
       <P>Hello there</P>
       <P>This is an example of a componentized blog post</P>
@@ -26,23 +26,23 @@ export default () => (
   </div>
 )
 
-const Hr = () => <hr className={css(styles.hr)} />
+const Hr = () => <hr className={styles.hr} />
 
-const styles = StyleSheet.create({
-  main: {
+const styles = {
+  main: style({
     margin: 'auto',
     maxWidth: '420px',
     padding: '10px'
-  },
+  }),
 
-  hr: {
+  hr: style({
     width: '100px',
     borderWidth: 0,
     margin: '20px auto',
     textAlign: 'center',
-    ':before': {
+    '::before': {
       content: '"***"',
       color: '#ccc'
     }
-  }
-})
+  })
+}
diff --git a/lib/css.js b/lib/css.js
@@ -1 +1 @@
-module.exports = require('aphrodite')
+module.exports = require('glamor')
diff --git a/lib/document.js b/lib/document.js
@@ -5,7 +5,7 @@ export default ({ head, css, html, data, dev, staticMarkup }) => {
   return <html>
     <head>
       {(head || []).map((h, i) => React.cloneElement(h, { key: i }))}
-      <style data-aphrodite='' dangerouslySetInnerHTML={{ __html: css.content }} />
+      <style dangerouslySetInnerHTML={{ __html: css }} />
     </head>
     <body>
       <div id='__next' dangerouslySetInnerHTML={{ __html: html }} />
diff --git a/lib/eval-script.js b/lib/eval-script.js
@@ -2,7 +2,7 @@ import React from 'react'
 import ReactDOM from 'react-dom'
 import App from '../lib/app'
 import Link from '../lib/link'
-import Css from '../lib/css'
+import * as Css from '../lib/css'
 import Head from '../lib/head'
 
 const modules = new Map([
diff --git a/package.json b/package.json
@@ -17,7 +17,6 @@
     "precommit": "npm run lint"
   },
   "dependencies": {
-    "aphrodite": "0.5.0",
     "babel-core": "6.17.0",
     "babel-generator": "6.17.0",
     "babel-loader": "6.2.5",
@@ -31,6 +30,7 @@
     "babel-runtime": "6.11.6",
     "cross-spawn": "4.0.2",
     "del": "2.2.2",
+    "glamor": "2.17.10",
     "glob-promise": "1.0.6",
     "htmlescape": "1.1.1",
     "loader-utils": "0.2.16",
diff --git a/pages/_error-debug.js b/pages/_error-debug.js
@@ -1,7 +1,7 @@
 import React from 'react'
 import stripAnsi from 'strip-ansi'
 import Head from 'next/head'
-import { css, StyleSheet } from 'next/css'
+import { style } from 'next/css'
 
 export default class ErrorDebug extends React.Component {
   static getInitialProps ({ err }) {
@@ -12,7 +12,7 @@ export default class ErrorDebug extends React.Component {
   render () {
     const { message, path } = this.props
 
-    return <div className={css(styles.errorDebug)}>
+    return <div className={styles.errorDebug}>
       <Head>
         <style dangerouslySetInnerHTML={{ __html: `
           body {
@@ -21,48 +21,36 @@ export default class ErrorDebug extends React.Component {
           }
         `}} />
       </Head>
-      <div className={css(styles.heading)}>Error in {path}</div>
-      <pre className={css(styles.message)}>{stripAnsi(message)}</pre>
+      <div className={styles.heading}>Error in {path}</div>
+      <pre className={styles.message}>{stripAnsi(message)}</pre>
     </div>
   }
 }
 
-const styles = StyleSheet.create({
-  body: {
+const styles = {
+  body: style({
     background: '#dc0067',
     margin: 0
-  },
+  }),
 
-  errorDebug: {
+  errorDebug: style({
     height: '100%',
     padding: '16px',
     boxSizing: 'border-box'
-  },
+  }),
 
-  message: {
+  message: style({
     fontFamily: 'menlo-regular',
     fontSize: '10px',
     color: '#fff',
     margin: 0
-  },
+  }),
 
-  heading: {
+  heading: style({
     fontFamily: 'sans-serif',
     fontSize: '13px',
     fontWeight: 'bold',
     color: '#ff90c6',
     marginBottom: '20px'
-  },
-
-  token: {
-    backgroundColor: '#000'
-  },
-
-  marker: {
-    color: '#000'
-  },
-
-  dim: {
-    color: '#e85b9b'
-  }
-})
+  })
+}
diff --git a/pages/_error.js b/pages/_error.js
@@ -1,5 +1,5 @@
 import React from 'react'
-import { css, StyleSheet } from 'next/css'
+import { style, merge } from 'next/css'
 
 export default class Error extends React.Component {
   static getInitialProps ({ res, xhr }) {
@@ -11,19 +11,19 @@ export default class Error extends React.Component {
     const { statusCode } = this.props
     const title = statusCode === 404 ? 'This page could not be found' : 'Internal Server Error'
 
-    return <div className={css(styles.error, styles['error_' + statusCode])}>
-      <div className={css(styles.text)}>
-        <h1 className={css(styles.h1)}>{statusCode}</h1>
-        <div className={css(styles.desc)}>
-          <h2 className={css(styles.h2)}>{title}.</h2>
+    return <div className={merge(styles.error, styles['error_' + statusCode])}>
+      <div className={styles.text}>
+        <h1 className={styles.h1}>{statusCode}</h1>
+        <div className={styles.desc}>
+          <h2 className={styles.h2}>{title}.</h2>
         </div>
       </div>
     </div>
   }
 }
 
-const styles = StyleSheet.create({
-  error: {
+const styles = {
+  error: style({
     color: '#000',
     background: '#fff',
     top: 0,
@@ -34,17 +34,17 @@ const styles = StyleSheet.create({
     fontFamily: '"SF UI Text", "Helvetica Neue", "Lucida Grande"',
     textAlign: 'center',
     paddingTop: '20%'
-  },
+  }),
 
-  desc: {
+  desc: style({
     display: 'inline-block',
     textAlign: 'left',
     lineHeight: '49px',
     height: '49px',
     verticalAlign: 'middle'
-  },
+  }),
 
-  h1: {
+  h1: style({
     display: 'inline-block',
     borderRight: '1px solid rgba(0, 0, 0,.3)',
     margin: 0,
@@ -53,12 +53,12 @@ const styles = StyleSheet.create({
     fontSize: '24px',
     fontWeight: 500,
     verticalAlign: 'top'
-  },
+  }),
 
-  h2: {
+  h2: style({
     fontSize: '14px',
     fontWeight: 'normal',
     margin: 0,
     padding: 0
-  }
-})
+  })
+}
diff --git a/server/render.js b/server/render.js
diff --git a/test/fixtures/basic/pages/css.js b/test/fixtures/basic/pages/css.js
diff --git a/test/index.js b/test/index.js

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-module.exports = require('aphrodite')`
	`1`	`+module.exports = require('glamor')`