Make sure NODE_ENV is production for react-dom to optimize

timneutkens · timneutkens · commit 01780fe7893b · 2017-10-29T00:58:17.000+02:00
diff --git a/bin/next b/bin/next
@@ -55,6 +55,9 @@ if (commands.has(cmd)) {
   args = process.argv.slice(2)
 }
 
+const defaultEnv = cmd === 'dev' ? 'development' : 'production'
+process.env.NODE_ENV = process.env.NODE_ENV || defaultEnv
+
 const bin = join(__dirname, 'next-' + cmd)
 
 const startProcess = () => {
diff --git a/bin/next-build b/bin/next-build
@@ -5,8 +5,6 @@ import parseArgs from 'minimist'
 import build from '../server/build'
 import { printAndExit } from '../lib/utils'
 
-process.env.NODE_ENV = process.env.NODE_ENV || 'production'
-
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
     h: 'help'
diff --git a/bin/next-dev b/bin/next-dev
@@ -7,8 +7,6 @@ import Server from '../server'
 import { printAndExit } from '../lib/utils'
 import pkgUp from 'pkg-up'
 
-process.env.NODE_ENV = process.env.NODE_ENV || 'development'
-
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
     h: 'help',
diff --git a/bin/next-export b/bin/next-export
@@ -5,8 +5,6 @@ import parseArgs from 'minimist'
 import exportApp from '../server/export'
 import { printAndExit } from '../lib/utils'
 
-process.env.NODE_ENV = process.env.NODE_ENV || 'production'
-
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
     h: 'help',
diff --git a/bin/next-start b/bin/next-start
@@ -4,8 +4,6 @@ import { resolve } from 'path'
 import parseArgs from 'minimist'
 import Server from '../server'
 
-process.env.NODE_ENV = process.env.NODE_ENV || 'production'
-
 const argv = parseArgs(process.argv.slice(2), {
   alias: {
     h: 'help',

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,9 @@ if (commands.has(cmd)) {`
`55`	`55`	`args = process.argv.slice(2)`
`56`	`56`	`}`
`57`	`57`
	`58`	`+const defaultEnv = cmd === 'dev' ? 'development' : 'production'`
	`59`	`+process.env.NODE_ENV = process.env.NODE_ENV \|\| defaultEnv`
	`60`	`+`
`58`	`61`	`const bin = join(__dirname, 'next-' + cmd)`
`59`	`62`
`60`	`63`	`const startProcess = () => {`