refactor: generate sourcemap file only in production, apollo server now dynamically configured, now in graphpack dev and build time can be port as arguments

rjoydip · rjoydip · commit a6d648a9b41b · 2018-10-20T18:57:15.000+05:30
diff --git a/packages/graphpack/bin/graphpack.js b/packages/graphpack/bin/graphpack.js
@@ -37,12 +37,14 @@ const startGraphPack = async () => {
   const compiler = webpack(config);
 
   require('yargs')
-    .command(['$0', 'dev'], 'Start graphpack dev server', {}, () =>
-      startDevServer({ compiler, config }),
-    )
-    .command('build', 'Create production build', {}, () =>
-      createProductionBuild({ compiler }),
-    ).argv;
+    .command(['$0', 'dev'], 'Start graphpack dev server', {}, (yargs) => {
+      process.env.PORT = yargs.port || yargs.p || yargs.PORT || yargs.P;
+      startDevServer({ compiler, config });
+    })
+    .command('build', 'Create production build', {}, (yargs) => {
+      process.env.PORT = yargs.port || yargs.p || yargs.PORT || yargs.P;
+      createProductionBuild({ compiler });
+    }).argv;
 };
 
 startGraphPack();
diff --git a/packages/graphpack/config/webpack.config.js b/packages/graphpack/config/webpack.config.js
@@ -12,7 +12,7 @@ if (hasBabelRc) {
 }
 
 module.exports = {
-  devtool: 'sourcemap',
+  devtool: IS_DEV ? 'sourcemap': 'none',
   entry: {
     // We take care of setting up entry file under lib/index.js
     index: ['graphpack'],
@@ -58,7 +58,7 @@ module.exports = {
     filename: '[name].js',
     libraryTarget: 'commonjs2',
     path: path.join(process.cwd(), './build'),
-    sourceMapFilename: '[name].map',
+    sourceMapFilename: '[name].map'
   },
   performance: {
     hints: false,
diff --git a/packages/graphpack/lib/server.js b/packages/graphpack/lib/server.js
@@ -29,7 +29,7 @@ const server = new ApolloServer({
 });
 
 server
-  .listen({ port: 4000 })
+  .listen({ port: (config.PORT || config.port) || (process.env.PORT || 4000) })
   .then(({ url }) => console.log(`🚀 Server ready at ${url}`));
 
 export default server;
