make sure module moving don't hang in circular chunk dependencies

sokra · sokra · commit f9b81a750956 · 2016-09-18T10:30:05.000+02:00
fixes webpack#2990
diff --git a/lib/optimize/EnsureChunkConditionsPlugin.js b/lib/optimize/EnsureChunkConditionsPlugin.js
@@ -13,10 +13,15 @@ EnsureChunkConditionsPlugin.prototype.apply = function(compiler) {
 				chunk.modules.slice().forEach(function(module) {
 					if(!module.chunkCondition) return;
 					if(!module.chunkCondition(chunk)) {
+						var usedChunks = module._EnsureChunkConditionsPlugin_usedChunks = (module._EnsureChunkConditionsPlugin_usedChunks || []).concat(chunk);
+						var newChunks = [];
 						chunk.parents.forEach(function(parent) {
-							parent.addModule(module);
+							if(usedChunks.indexOf(parent) < 0) {
+								parent.addModule(module);
+								newChunks.push(parent);
+							}
 						});
-						module.rewriteChunkInReasons(chunk, chunk.parents);
+						module.rewriteChunkInReasons(chunk, newChunks);
 						chunk.removeModule(module);
 						changed = true;
 					}
