Merge pull request webpack#5534 from webpack/bugfix/incorrect-graph

sokra · web-flow · commit f75418f6683a · 2017-08-16T15:07:04.000+02:00
Ensure that graph structure stay consistent
diff --git a/lib/Module.js b/lib/Module.js
@@ -73,6 +73,7 @@ class Module extends DependenciesBlock {
 
 	setChunks(chunks) {
 		this._chunks = new SortableSet(chunks, sortById);
+		this._chunksDebugIdent = undefined;
 	}
 
 	addChunk(chunk) {
diff --git a/lib/optimize/EnsureChunkConditionsPlugin.js b/lib/optimize/EnsureChunkConditionsPlugin.js
@@ -22,6 +22,7 @@ class EnsureChunkConditionsPlugin {
 							chunk.parents.forEach((parent) => {
 								if(!usedChunks.has(parent)) {
 									parent.addModule(module);
+									module.addChunk(parent);
 									newChunks.push(parent);
 								}
 							});
diff --git a/lib/optimize/ModuleConcatenationPlugin.js b/lib/optimize/ModuleConcatenationPlugin.js
@@ -163,6 +163,7 @@ class ModuleConcatenationPlugin {
 					}
 					chunks.forEach(chunk => {
 						chunk.addModule(newModule);
+						newModule.addChunk(chunk);
 						if(chunk.entryModule === concatConfiguration.rootModule)
 							chunk.entryModule = newModule;
 					});

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ class Module extends DependenciesBlock {`
`73`	`73`
`74`	`74`	`setChunks(chunks) {`
`75`	`75`	`this._chunks = new SortableSet(chunks, sortById);`
	`76`	`+ this._chunksDebugIdent = undefined;`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`addChunk(chunk) {`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ class EnsureChunkConditionsPlugin {`
`22`	`22`	`chunk.parents.forEach((parent) => {`
`23`	`23`	`if(!usedChunks.has(parent)) {`
`24`	`24`	`parent.addModule(module);`
	`25`	`+ module.addChunk(parent);`
`25`	`26`	`newChunks.push(parent);`
`26`	`27`	`}`
`27`	`28`	`});`
Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,7 @@ class ModuleConcatenationPlugin {`
`163`	`163`	`}`
`164`	`164`	`chunks.forEach(chunk => {`
`165`	`165`	`chunk.addModule(newModule);`
	`166`	`+ newModule.addChunk(chunk);`
`166`	`167`	`if(chunk.entryModule === concatConfiguration.rootModule)`
`167`	`168`	`chunk.entryModule = newModule;`
`168`	`169`	`});`