fix inner loop of "remove" method

timse · timse · commit f4d8c5f20f99 · 2017-02-14T21:16:10.000+11:00
as it is not guaranteed that the the chunk has parents the loop may not be run
this could lead to stale "this" still being a parent of one of its childs.
therefore we have to loop the chunks again.
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -157,15 +157,23 @@ class Chunk {
 				chunk.addParent(parentChunk);
 				// add "sub chunk" to parent
 				parentChunk.addChunk(chunk);
-
-				// remove this as parent of every "sub chunk"
-				const idx = chunk.parents.indexOf(this);
-				if(idx >= 0) {
-					chunk.parents.splice(idx, 1);
-				}
 			});
 		});
 
+		/**
+		 * we need to iterate again over the chunks
+		 * to remove this from the chunks parents.
+		 * This can not be done in the above loop
+		 * as it is not garuanteed that `this.parents` contains anything.
+		 */
+		this.chunks.forEach(chunk => {
+			// remove this as parent of every "sub chunk"
+			const idx = chunk.parents.indexOf(this);
+			if(idx >= 0) {
+				chunk.parents.splice(idx, 1);
+			}
+		});
+
 		// cleanup blocks
 		this.blocks.forEach(block => {
 			const idx = block.chunks.indexOf(this);
