refactor(ConstPlugin): upgrade to ES6 (webpack#3845)

willmendesneto · TheLarkInn · commit ef8c6fb1792f · 2017-01-08T12:07:44.000-06:00
diff --git a/lib/ConstPlugin.js b/lib/ConstPlugin.js
@@ -2,61 +2,63 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-var ConstDependency = require("./dependencies/ConstDependency");
-var BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
+"use strict";
 
-var NullFactory = require("./NullFactory");
+const ConstDependency = require("./dependencies/ConstDependency");
+const BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
+const NullFactory = require("./NullFactory");
 
-function getQuery(request) {
-	var i = request.indexOf("?");
-	return i < 0 ? "" : request.substr(i);
+const getQuery = (request) => {
+	const i = request.indexOf("?");
+	return request.indexOf("?") < 0 ? "" : request.substr(i);
 }
 
-function ConstPlugin() {}
-module.exports = ConstPlugin;
-
-ConstPlugin.prototype.apply = function(compiler) {
-	compiler.plugin("compilation", function(compilation, params) {
-		compilation.dependencyFactories.set(ConstDependency, new NullFactory());
-		compilation.dependencyTemplates.set(ConstDependency, new ConstDependency.Template());
+class ConstPlugin {
+	apply(compiler) {
+		compiler.plugin("compilation", (compilation, params) => {
+			compilation.dependencyFactories.set(ConstDependency, new NullFactory());
+			compilation.dependencyTemplates.set(ConstDependency, new ConstDependency.Template());
 
-		params.normalModuleFactory.plugin("parser", function(parser) {
-			parser.plugin("statement if", function(statement) {
-				var param = this.evaluateExpression(statement.test);
-				var bool = param.asBool();
-				if(typeof bool === "boolean") {
-					if(statement.test.type !== "Literal") {
-						var dep = new ConstDependency(bool + "", param.range);
-						dep.loc = statement.loc;
-						this.state.current.addDependency(dep);
+			params.normalModuleFactory.plugin("parser", parser => {
+				parser.plugin("statement if", function(statement) {
+					const param = this.evaluateExpression(statement.test);
+					const bool = param.asBool();
+					if(typeof bool === "boolean") {
+						if(statement.test.type !== "Literal") {
+							const dep = new ConstDependency(`${bool}`, param.range);
+							dep.loc = statement.loc;
+							this.state.current.addDependency(dep);
+						}
+						return bool;
 					}
-					return bool;
-				}
-			});
-			parser.plugin("expression ?:", function(expression) {
-				var param = this.evaluateExpression(expression.test);
-				var bool = param.asBool();
-				if(typeof bool === "boolean") {
-					if(expression.test.type !== "Literal") {
-						var dep = new ConstDependency(" " + bool + "", param.range);
-						dep.loc = expression.loc;
-						this.state.current.addDependency(dep);
+				});
+				parser.plugin("expression ?:", function(expression) {
+					const param = this.evaluateExpression(expression.test);
+					const bool = param.asBool();
+					if(typeof bool === "boolean") {
+						if(expression.test.type !== "Literal") {
+							const dep = new ConstDependency(` ${bool}`, param.range);
+							dep.loc = expression.loc;
+							this.state.current.addDependency(dep);
+						}
+						return bool;
 					}
-					return bool;
-				}
-			});
-			parser.plugin("evaluate Identifier __resourceQuery", function(expr) {
-				if(!this.state.module) return;
-				var res = new BasicEvaluatedExpression();
-				res.setString(getQuery(this.state.module.resource));
-				res.setRange(expr.range);
-				return res;
-			});
-			parser.plugin("expression __resourceQuery", function() {
-				if(!this.state.module) return;
-				this.state.current.addVariable("__resourceQuery", JSON.stringify(getQuery(this.state.module.resource)));
-				return true;
+				});
+				parser.plugin("evaluate Identifier __resourceQuery", function(expr) {
+					if(!this.state.module) return;
+					const res = new BasicEvaluatedExpression();
+					res.setString(getQuery(this.state.module.resource));
+					res.setRange(expr.range);
+					return res;
+				});
+				parser.plugin("expression __resourceQuery", function() {
+					if(!this.state.module) return;
+					this.state.current.addVariable("__resourceQuery", JSON.stringify(getQuery(this.state.module.resource)));
+					return true;
+				});
 			});
 		});
-	});
-};
+	}
+}
+
+module.exports = ConstPlugin;
