return error object for compiler dependency errors

rrharvey · rrharvey · commit ecd02195a29b · 2017-09-11T08:55:28.000-05:00
diff --git a/lib/MultiCompiler.js b/lib/MultiCompiler.js
@@ -114,7 +114,8 @@ module.exports = class MultiCompiler extends Tapable {
 			errors.unshift("Circular dependency found in compiler dependencies.");
 		}
 		if(errors.length > 0) {
-			callback(errors.join("\n"));
+			const message = errors.join("\n");
+			callback(new Error(message));
 			return false;
 		}
 		return true;
diff --git a/test/MultiCompiler.test.js b/test/MultiCompiler.test.js
@@ -419,7 +419,8 @@ describe("MultiCompiler", () => {
 				env.compiler1WatchCallbacks.length.should.be.exactly(0);
 				env.compiler2WatchCallbacks.length.should.be.exactly(0);
 				env.callback.callCount.should.be.exactly(1);
-				env.callback.getCall(0).args[0].should.match(/`compiler2` not found/);
+				env.callback.getCall(0).args[0].should.be.Error();
+				should(env.callback.getCall(0).args[1]).be.undefined();
 			});
 		});
 
@@ -445,7 +446,8 @@ describe("MultiCompiler", () => {
 				env.compiler1WatchCallbacks.length.should.be.exactly(0);
 				env.compiler2WatchCallbacks.length.should.be.exactly(0);
 				env.callback.callCount.should.be.exactly(1);
-				env.callback.getCall(0).args[0].should.equal("Circular dependency found in compiler dependencies.");
+				env.callback.getCall(0).args[0].should.be.Error();
+				should(env.callback.getCall(0).args[1]).be.undefined();
 			});
 		});
 	});
@@ -557,7 +559,8 @@ describe("MultiCompiler", () => {
 				env.compiler1RunCallbacks.length.should.be.exactly(0);
 				env.compiler2RunCallbacks.length.should.be.exactly(0);
 				env.callback.callCount.should.be.exactly(1);
-				env.callback.getCall(0).args[0].should.match(/`compiler2` not found/);
+				env.callback.getCall(0).args[0].should.be.Error();
+				should(env.callback.getCall(0).args[1]).be.undefined();
 			});
 		});
 
@@ -578,7 +581,8 @@ describe("MultiCompiler", () => {
 				env.compiler1RunCallbacks.length.should.be.exactly(0);
 				env.compiler2RunCallbacks.length.should.be.exactly(0);
 				env.callback.callCount.should.be.exactly(1);
-				env.callback.getCall(0).args[0].should.equal("Circular dependency found in compiler dependencies.");
+				env.callback.getCall(0).args[0].should.be.Error();
+				should(env.callback.getCall(0).args[1]).be.undefined();
 			});
 		});
 	});

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,8 @@ module.exports = class MultiCompiler extends Tapable {`
`114`	`114`	`errors.unshift("Circular dependency found in compiler dependencies.");`
`115`	`115`	`}`
`116`	`116`	`if(errors.length > 0) {`
`117`		`- callback(errors.join("\n"));`
	`117`	`+ const message = errors.join("\n");`
	`118`	`+ callback(new Error(message));`
`118`	`119`	`return false;`
`119`	`120`	`}`
`120`	`121`	`return true;`