Merge pull request webpack#6932 from mohsen1/hideStack

sokra · web-flow · commit e65751ac6f83 · 2018-04-04T11:06:39.000+02:00
Add HarmonyLinkingError class
diff --git a/lib/HarmonyLinkingError.js b/lib/HarmonyLinkingError.js
@@ -0,0 +1,18 @@
+/*
+	MIT License http://www.opensource.org/licenses/mit-license.php
+*/
+"use strict";
+
+const WebpackError = require("./WebpackError");
+
+module.exports = class HarmonyLinkingError extends WebpackError {
+	/** @param {string} message Error message */
+	constructor(message) {
+		super();
+		this.name = "HarmonyLinkingError";
+		this.message = message;
+		this.hideStack = true;
+
+		Error.captureStackTrace(this, this.constructor);
+	}
+};
diff --git a/lib/dependencies/HarmonyExportImportedSpecifierDependency.js b/lib/dependencies/HarmonyExportImportedSpecifierDependency.js
@@ -7,6 +7,7 @@
 const DependencyReference = require("./DependencyReference");
 const HarmonyImportDependency = require("./HarmonyImportDependency");
 const Template = require("../Template");
+const HarmonyLinkingError = require("../HarmonyLinkingError");
 
 class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 	constructor(
@@ -334,11 +335,11 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 				const exportName = this.id
 					? `the named export '${this.id}'`
 					: "the namespace object";
-				const err = new Error(
-					`Can't reexport ${exportName} from non EcmaScript module (only default export is available)`
-				);
-				err.hideStack = true;
-				return [err];
+				return [
+					new HarmonyLinkingError(
+						`Can't reexport ${exportName} from non EcmaScript module (only default export is available)`
+					)
+				];
 			}
 			return;
 		}
@@ -358,9 +359,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
 		const errorMessage = `"export '${
 			this.id
 		}'${idIsNotNameMessage} was not found in '${this.userRequest}'`;
-		const err = new Error(errorMessage);
-		err.hideStack = true;
-		return [err];
+		return [new HarmonyLinkingError(errorMessage)];
 	}
 
 	updateHash(hash) {
diff --git a/lib/dependencies/HarmonyImportSpecifierDependency.js b/lib/dependencies/HarmonyImportSpecifierDependency.js
@@ -6,6 +6,7 @@
 
 const DependencyReference = require("./DependencyReference");
 const HarmonyImportDependency = require("./HarmonyImportDependency");
+const HarmonyLinkingError = require("../HarmonyLinkingError");
 
 class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
 	constructor(
@@ -78,11 +79,11 @@ class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
 				const exportName = this.id
 					? `the named export '${this.id}'`
 					: "the namespace object";
-				const err = new Error(
-					`Can't import ${exportName} from non EcmaScript module (only default export is available)`
-				);
-				err.hideStack = true;
-				return [err];
+				return [
+					new HarmonyLinkingError(
+						`Can't import ${exportName} from non EcmaScript module (only default export is available)`
+					)
+				];
 			}
 			return;
 		}
@@ -102,9 +103,7 @@ class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
 		const errorMessage = `"export '${
 			this.id
 		}'${idIsNotNameMessage} was not found in '${this.userRequest}'`;
-		const err = new Error(errorMessage);
-		err.hideStack = true;
-		return [err];
+		return [new HarmonyLinkingError(errorMessage)];
 	}
 
 	// implement this method to allow the occurrence order plugin to count correctly
diff --git a/test/cases/compile/error-hide-stack/loader.js b/test/cases/compile/error-hide-stack/loader.js
@@ -3,4 +3,4 @@ module.exports = function() {
 	err.stack = "Stack";
 	err.hideStack = true;
 	throw err;
-};
+};
