Merge pull request webpack#3881 from timse/add-comment-to-sort

sokra · web-flow · commit e016e97529a3 · 2017-01-10T18:12:37.000+01:00
add comments to clarify why a sort is needed here.
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -967,7 +967,13 @@ class Compilation extends Tapable {
 			hash.update(child.hash);
 		});
 		let chunk;
+		// clone needed as sort below is inplace mutation
 		const chunks = this.chunks.slice();
+		/**
+		 * sort here will bring all "falsy" values to the beginning
+		 * this is needed as the "hasRuntime()" chunks are dependent on the
+		 * hashes of the non-runtime chunks.
+		 */
 		chunks.sort((a, b) => {
 			const aEntry = a.hasRuntime();
 			const bEntry = b.hasRuntime();
