refactor maintemplate to handle set instead of array

timse · timse · commit dbdc39d86e7d · 2017-06-24T11:39:46.000+10:00
diff --git a/lib/MainTemplate.js b/lib/MainTemplate.js
@@ -199,13 +199,16 @@ module.exports = class MainTemplate extends Template {
 
 	entryPointInChildren(chunk) {
 		const checkChildren = (chunk, alreadyCheckedChunks) => {
-			return chunk.chunks.some((child) => {
-				if(alreadyCheckedChunks.indexOf(child) >= 0) return;
-				alreadyCheckedChunks.push(child);
-				return child.hasEntryModule() || checkChildren(child, alreadyCheckedChunks);
-			});
+			for(const child of chunk.getChunks()) {
+				if(!alreadyCheckedChunks.has(child)) {
+					alreadyCheckedChunks.add(child);
+					if(child.hasEntryModule() || checkChildren(child, alreadyCheckedChunks)) {
+						return true;
+					}
+				}
+			}
 		};
-		return checkChildren(chunk, []);
+		return checkChildren(chunk, new Set()) === true;
 	}
 
 	getPublicPath(options) {
