fix test and linting

timse · timse · commit db2626595cf0 · 2017-02-16T19:31:58.000+11:00
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
@@ -339,6 +339,9 @@ class NormalModule extends Module {
 	}
 
 	splitVariablesInUniqueNamedChunks(vars) {
+		const startState = [
+			[]
+		];
 		return vars.reduce((chunks, variable) => {
 			const current = chunks[chunks.length - 1];
 			// check if variable with same name exists already
@@ -353,7 +356,7 @@ class NormalModule extends Module {
 				current.push(variable);
 			}
 			return chunks;
-		}, [[]]);
+		}, startState);
 	}
 
 	sourceBlock(block, availableVars, dependencyTemplates, source, outputOptions, requestShortener) {
@@ -369,7 +372,12 @@ class NormalModule extends Module {
 				variable, availableVars, dependencyTemplates, outputOptions, requestShortener))
 			.filter(Boolean);
 
-		// if we actually have variables
+		/**
+		 * if we actually have variables
+		 * this is important as how #splitVariablesInUniqueNamedChunks works
+		 * it will always return an array in an array which would lead to a IIFE wrapper around
+		 * a module if we do this with an empty vars array.
+		 */
 		if(vars.length > 0) {
 			/**
 			 * Split all variables up into chunks of unique names.
diff --git a/test/NormalModule.test.js b/test/NormalModule.test.js
@@ -246,25 +246,22 @@ describe("NormalModule", function() {
 		let variables;
 		beforeEach(function() {
 			variables = [{
-					name: "foo"
-				},
-				{
-					name: "bar"
-				},
-				{
-					name: "baz"
-				},
-				{
-					name: "some"
-				},
-				{
-					name: "more"
-				}
-			];
+				name: "foo"
+			}, {
+				name: "bar"
+			}, {
+				name: "baz"
+			}, {
+				name: "some"
+			}, {
+				name: "more"
+			}];
 		});
 		describe("given an empty array of vars", function() {
 			it("returns an empty array", function() {
-				normalModule.splitVariablesInUniqueNamedChunks([]).should.eql([]);
+				normalModule.splitVariablesInUniqueNamedChunks([]).should.eql([
+					[]
+				]);
 			});
 		});
 		describe("given an array of distrinct variables", function() {
