Merge pull request webpack#3601 from webpack/bugfix/delete-assets

sokra · web-flow · commit cb4c209fcf15 · 2016-12-28T15:37:06.000+01:00
fixes webpack#3596
diff --git a/lib/performance/SizeLimitsPlugin.js b/lib/performance/SizeLimitsPlugin.js
@@ -34,7 +34,11 @@ SizeLimitsPlugin.prototype.apply = function(compiler) {
 			return files
 				.filter(assetFilter)
 				.map(function(file) {
-					return compilation.assets[file].size()
+					return compilation.assets[file];
+				})
+				.filter(Boolean)
+				.map(function(asset) {
+					return asset.size()
 				})
 				.reduce(function(currentSize, nextSize) {
 					return currentSize + nextSize
diff --git a/test/configCases/issues/issue-3596/b.js b/test/configCases/issues/issue-3596/b.js
@@ -0,0 +1,3 @@
+it("should not be executed", function() {
+	throw new Error("should not be executed");
+});
diff --git a/test/configCases/issues/issue-3596/index.js b/test/configCases/issues/issue-3596/index.js
@@ -0,0 +1 @@
+it("should compile correctly", function() {});
diff --git a/test/configCases/issues/issue-3596/webpack.config.js b/test/configCases/issues/issue-3596/webpack.config.js
@@ -0,0 +1,17 @@
+module.exports = {
+	entry: {
+		bundle0: "./index",
+		b: "./b"
+	},
+	output: {
+		filename: "[name].js"
+	},
+	plugins: [
+		function() {
+			this.plugin("emit", function(compilation, callback) {
+				delete compilation.assets["b.js"];
+				callback();
+			})
+		}
+	]
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+it("should not be executed", function() {`
	`2`	`+ throw new Error("should not be executed");`
	`3`	`+});`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+it("should compile correctly", function() {});`