Fix webpack#412 - Support for holes inside Arrays

hmalphettes · hmalphettes · commit c2cc1dd231eb · 2014-08-19T09:59:35.000+08:00
An array with a hole such as `[,'foo']` is parsed by Esprima as null. Skip its evaluation. Reference: https://code.google.com/p/esprima/issues/detail?id=525#c18 ``` According to https://developer.mozilla.org/en-US/docs/SpiderMonkey/Parser_API#Expressions: interface ArrayExpression <: Expression { type: "ArrayExpression"; elements: [ Expression | null ]; } ```
diff --git a/lib/Parser.js b/lib/Parser.js
@@ -310,7 +310,7 @@ Parser.prototype.initializeEvaluating = function() {
 	});
 	this.plugin("evaluate ArrayExpression", function(expr) {
 		var items = expr.elements.map(function(element) {
-			return this.evaluateExpression(element);
+			return element !== null && this.evaluateExpression(element);
 		}, this);
 		if(items.filter(function(i) { return !i; }).length > 0) return;
 		return new BasicEvaluatedExpression().setItems(items).setRange(expr.range);
