convert algorithm to iterative, use less memory

sokra · sokra · commit beccf941a986 · 2017-12-01T11:26:53.000+01:00
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -536,43 +536,64 @@ class Chunk {
 	}
 
 	getChunkMaps(includeEntries, realHash) {
-		const chunksProcessed = new Set();
 		const chunkHashMap = Object.create(null);
 		const chunkNameMap = Object.create(null);
-		const addChunk = chunk => {
-			if(chunksProcessed.has(chunk)) return;
-			chunksProcessed.add(chunk);
+
+		const queue = [this];
+		const chunksEnqueued = new Set([this]);
+
+		while(queue.length > 0) {
+			const chunk = queue.pop();
 			if(!chunk.hasRuntime() || includeEntries) {
 				chunkHashMap[chunk.id] = realHash ? chunk.hash : chunk.renderedHash;
 				if(chunk.name)
 					chunkNameMap[chunk.id] = chunk.name;
 			}
-			chunk._chunks.forEach(addChunk);
-		};
-		addChunk(this);
+			for(const child of chunk.chunksIterable) {
+				if(chunksEnqueued.has(child)) continue;
+				chunksEnqueued.add(child);
+				queue.push(child);
+			}
+		}
+
 		return {
 			hash: chunkHashMap,
 			name: chunkNameMap
 		};
 	}
 
 	getChunkModuleMaps(includeEntries, filterFn) {
-		const chunksProcessed = new Set();
 		const chunkModuleIdMap = Object.create(null);
 		const chunkModuleHashMap = Object.create(null);
-		(function addChunk(chunk) {
-			if(chunksProcessed.has(chunk)) return;
-			chunksProcessed.add(chunk);
+
+		const chunksEnqueued = new Set([this]);
+		const queue = [this];
+
+		while(queue.length > 0) {
+			const chunk = queue.pop();
 			if(!chunk.hasRuntime() || includeEntries) {
-				const array = chunk.getModules().filter(filterFn);
-				if(array.length > 0)
-					chunkModuleIdMap[chunk.id] = array.map(m => m.id).sort();
-				for(const m of array) {
-					chunkModuleHashMap[m.id] = m.renderedHash;
+				let array = undefined;
+				for(const module of chunk.modulesIterable) {
+					if(filterFn(module)) {
+						if(array === undefined) {
+							array = [];
+							chunkModuleIdMap[chunk.id] = array;
+						}
+						array.push(module.id);
+						chunkModuleHashMap[module.id] = module.renderedHash;
+					}
+				}
+				if(array !== undefined) {
+					array.sort();
 				}
 			}
-			chunk._chunks.forEach(addChunk);
-		}(this));
+			for(const child of chunk.chunksIterable) {
+				if(chunksEnqueued.has(child)) continue;
+				chunksEnqueued.add(child);
+				queue.push(child);
+			}
+		}
+
 		return {
 			id: chunkModuleIdMap,
 			hash: chunkModuleHashMap
@@ -585,8 +606,9 @@ class Chunk {
 
 		while(queue.length > 0) {
 			const chunk = queue.pop();
-			if(chunk.getModules().some(filterFn))
-				return true;
+			for(const module of chunk.modulesIterable)
+				if(filterFn(module))
+					return true;
 			for(const next of chunk.chunksIterable) {
 				if(!chunksProcessed.has(next)) {
 					chunksProcessed.add(next);
