Fix issue webpack#2221 by adding a newline character to generated code

mastercactapus · mastercactapus · commit ba803870477e · 2016-03-22T19:52:51.000Z
Add a newline prefix to the code generated for non-immutable harmony exports. This
resolves a case where export statements without a trailing semicolon would cause
webpack to generate a bundle with invalid syntax.
diff --git a/lib/dependencies/HarmonyExportSpecifierDependency.js b/lib/dependencies/HarmonyExportSpecifierDependency.js
@@ -39,7 +39,7 @@ HarmonyExportSpecifierDependency.Template.prototype.apply = function(dep, source
 	} else if(dep.immutable) {
 		content = "/* harmony export */ exports[" + JSON.stringify(used) + "] = " + dep.id + ";";
 	} else {
-		content = "/* harmony export */ Object.defineProperty(exports, " + JSON.stringify(used) + ", {configurable: false, enumerable: true, get: function() { return " + dep.id + "; }});";
+		content = "\n/* harmony export */ Object.defineProperty(exports, " + JSON.stringify(used) + ", {configurable: false, enumerable: true, get: function() { return " + dep.id + "; }});";
 	}
 	source.insert(dep.position, content);
 
diff --git a/test/cases/compile/issue2221/exportvar.js b/test/cases/compile/issue2221/exportvar.js
@@ -0,0 +1 @@
+export var foo = "bar"
diff --git a/test/cases/compile/issue2221/index.js b/test/cases/compile/issue2221/index.js
@@ -0,0 +1,3 @@
+it("should compile non-immutable exports with missing semicolons", function(){
+    require("./exportvar");
+});

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ HarmonyExportSpecifierDependency.Template.prototype.apply = function(dep, source`
`39`	`39`	`} else if(dep.immutable) {`
`40`	`40`	`content = "/* harmony export */ exports[" + JSON.stringify(used) + "] = " + dep.id + ";";`
`41`	`41`	`} else {`
`42`		`- content = "/* harmony export */ Object.defineProperty(exports, " + JSON.stringify(used) + ", {configurable: false, enumerable: true, get: function() { return " + dep.id + "; }});";`
	`42`	`+ content = "\n/* harmony export */ Object.defineProperty(exports, " + JSON.stringify(used) + ", {configurable: false, enumerable: true, get: function() { return " + dep.id + "; }});";`
`43`	`43`	`}`
`44`	`44`	`source.insert(dep.position, content);`
`45`	`45`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+it("should compile non-immutable exports with missing semicolons", function(){`
	`2`	`+ require("./exportvar");`
	`3`	`+});`