Triple-check if value is not undefined

einarlove · einarlove · commit b25ccfc28d37 · 2016-12-24T23:42:11.000Z
diff --git a/lib/EnvironmentPlugin.js b/lib/EnvironmentPlugin.js
@@ -34,7 +34,7 @@ EnvironmentPlugin.prototype.apply = function(compiler) {
 			});
 		}
 
-		defs["process.env." + key] = value ? JSON.stringify(value) : "undefined";
+		defs["process.env." + key] = value === 'undefined' ? 'undefined' : JSON.stringify(value);
 
 		return defs;
 	}.bind(this), {});

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ EnvironmentPlugin.prototype.apply = function(compiler) {`
`34`	`34`	`});`
`35`	`35`	`}`
`36`	`36`
`37`		`- defs["process.env." + key] = value ? JSON.stringify(value) : "undefined";`
	`37`	`+ defs["process.env." + key] = value === 'undefined' ? 'undefined' : JSON.stringify(value);`
`38`	`38`
`39`	`39`	`return defs;`
`40`	`40`	`}.bind(this), {});`