do not reassign variable with different values in ModuleTemplate

timse · timse · commit b05a4af2fdf0 · 2017-02-05T10:32:52.000+11:00
diff --git a/lib/ModuleTemplate.js b/lib/ModuleTemplate.js
@@ -11,10 +11,10 @@ module.exports = class ModuleTemplate extends Template {
 		super(outputOptions);
 	}
 	render(module, dependencyTemplates, chunk) {
-		let moduleSource = module.source(dependencyTemplates, this.outputOptions, this.requestShortener);
-		moduleSource = this.applyPluginsWaterfall("module", moduleSource, module, chunk, dependencyTemplates);
-		moduleSource = this.applyPluginsWaterfall("render", moduleSource, module, chunk, dependencyTemplates);
-		return this.applyPluginsWaterfall("package", moduleSource, module, chunk, dependencyTemplates);
+		const moduleSource = module.source(dependencyTemplates, this.outputOptions, this.requestShortener);
+		const moduleSourcePostModule = this.applyPluginsWaterfall("module", moduleSource, module, chunk, dependencyTemplates);
+		const moduleSourcePostRender = this.applyPluginsWaterfall("render", moduleSourcePostModule, module, chunk, dependencyTemplates);
+		return this.applyPluginsWaterfall("package", moduleSourcePostRender, module, chunk, dependencyTemplates);
 	}
 	updateHash(hash) {
 		hash.update("1");
