change sortByField to prevent deadlock

timse · timse · commit a72eab8e4557 · 2017-02-05T13:09:56.000+11:00
- returning a function fails the linter as it wants `return()=&gt;` without space
- removing the space fails eslint
diff --git a/lib/Stats.js b/lib/Stats.js
@@ -80,18 +80,16 @@ class Stats {
 			};
 		};
 
-		const sortByField = (field) => {
+		const sortByField = (field) => (a, b) => {
 			if(!field) {
-				return () => 0;
+				return 0;
 			}
 
-			return (a, b) => {
-				if(a[field] === null && b[field] === null) return 0;
-				if(a[field] === null) return 1;
-				if(b[field] === null) return -1;
-				if(a[field] === b[field]) return 0;
-				return a[field] < b[field] ? -1 : 1;
-			};
+			if(a[field] === null && b[field] === null) return 0;
+			if(a[field] === null) return 1;
+			if(b[field] === null) return -1;
+			if(a[field] === b[field]) return 0;
+			return a[field] < b[field] ? -1 : 1;
 		};
 
 		const formatError = (e) => {
