apply optimizing on extracted chunks too

sokra · sokra · commit a2cc7dbd381d · 2014-09-23T08:42:54.000+02:00
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -24,10 +24,12 @@ CommonsChunkPlugin.prototype.apply = function(compiler) {
 	var minCount = this.minCount;
 	var entryPoints = this.entryPoints;
 	compiler.plugin("this-compilation", function(compilation) {
-		compilation.plugin("optimize-chunks", function(chunks) {
+		compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], function(chunks) {
 			var commonModulesCount = [];
 			var commonModules = [];
-			var commonChunk = this.addChunk(chunkName);
+			var commonChunk = chunks.filter(function(chunk) {
+				return chunk.name === chunkName;
+			})[0] || this.addChunk(chunkName);
 			var usedChunks = chunks.filter(function(chunk) {
 				if(chunk === commonChunk) return false;
 				if(!chunk.entry) return false;
diff --git a/lib/optimize/RemoveEmptyChunksPlugin.js b/lib/optimize/RemoveEmptyChunksPlugin.js
@@ -8,7 +8,7 @@ module.exports = RemoveEmptyChunksPlugin;
 
 RemoveEmptyChunksPlugin.prototype.apply = function(compiler) {
 	compiler.plugin("compilation", function(compilation) {
-		compilation.plugin("optimize-chunks", function(chunks) {
+		compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], function(chunks) {
 			chunks.filter(function(chunk) {
 				return chunk.isEmpty() && !chunk.initial;
 			}).forEach(function(chunk) {
diff --git a/lib/optimize/RemoveParentModulesPlugin.js b/lib/optimize/RemoveParentModulesPlugin.js
@@ -35,7 +35,7 @@ module.exports = RemoveParentModulesPlugin;
 
 RemoveParentModulesPlugin.prototype.apply = function(compiler) {
 	compiler.plugin("compilation", function(compilation) {
-		compilation.plugin("optimize-chunks", function(chunks) {
+		compilation.plugin(["optimize-chunks", "optimize-extracted-chunks"], function(chunks) {
 			chunks.forEach(function(chunk) {
 				chunk.modules.slice().forEach(function(module) {
 					if(chunk.entry) return;
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
 		"clone": "~0.1.15",
 		"webpack-core": "~0.4.8",
 		"node-libs-browser": "~0.4.0",
-		"tapable": "~0.1.6"
+		"tapable": "~0.1.8"
 	},
 	"licenses": [
 		{

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`"clone": "~0.1.15",`
`15`	`15`	`"webpack-core": "~0.4.8",`
`16`	`16`	`"node-libs-browser": "~0.4.0",`
`17`		`- "tapable": "~0.1.6"`
	`17`	`+ "tapable": "~0.1.8"`
`18`	`18`	`},`
`19`	`19`	`"licenses": [`
`20`	`20`	`{`