cache parent checks, check faster array for contain

sokra · sokra · commit 996b6c80ae2d · 2016-04-10T23:55:37.000+02:00
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -2,9 +2,12 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+var debugId = 1000;
+
 function Chunk(name, module, loc) {
 	this.id = null;
 	this.ids = null;
+	this.debugId = debugId++;
 	this.name = name;
 	this.modules = [];
 	this.chunks = [];
diff --git a/lib/optimize/RemoveParentModulesPlugin.js b/lib/optimize/RemoveParentModulesPlugin.js
@@ -2,8 +2,18 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+function chunkContainsModule(chunk, module) {
+	var chunks = module.chunks;
+	var modules = chunk.modules;
+	if(chunks.length > modules.length) {
+		return chunks.indexOf(chunk) >= 0;
+	} else {
+		return modules.indexOf(module) >= 0;
+	}
+}
+
 function hasModule(chunk, module, checkedChunks) {
-	if(chunk.modules.indexOf(module) >= 0) return [chunk];
+	if(chunkContainsModule(chunk, module)) return [chunk];
 	if(chunk.entry) return false;
 	return allHaveModule(chunk.parents.filter(function(c) {
 		return checkedChunks.indexOf(c) < 0;
@@ -29,16 +39,34 @@ function addToSet(set, items) {
 	});
 }
 
+function debugIds(chunks) {
+	var list = chunks.map(function(chunk) {
+		return chunk.debugId;
+	});
+	if(list.some(function(dId) {
+		return typeof dId !== "number";
+	})) return "no";
+	list.sort();
+	return list.join(",");
+}
+
 function RemoveParentModulesPlugin() {}
 module.exports = RemoveParentModulesPlugin;
 
 RemoveParentModulesPlugin.prototype.apply = function(compiler) {
 	compiler.plugin("compilation", function(compilation) {
 		compilation.plugin(["optimize-chunks-basic", "optimize-extracted-chunks-basic"], function(chunks) {
 			chunks.forEach(function(chunk) {
+				var cache = {};
 				chunk.modules.slice().forEach(function(module) {
 					if(chunk.entry) return;
-					var parentChunksWithModule = allHaveModule(chunk.parents, module);
+					var dId = "$" + debugIds(module.chunks);
+					var parentChunksWithModule;
+					if((dId in cache) && dId !== "$no")  {
+						parentChunksWithModule = cache[dId];
+					} else {
+						parentChunksWithModule = cache[dId] = allHaveModule(chunk.parents, module);
+					}
 					if(parentChunksWithModule) {
 						module.rewriteChunkInReasons(chunk, parentChunksWithModule);
 						chunk.removeModule(module);
