fix useless-escape linting issues

sokra · sokra · commit 991b360c9055 · 2017-07-24T11:54:06.000+02:00
diff --git a/bin/convert-argv.js b/bin/convert-argv.js
@@ -300,7 +300,7 @@ module.exports = function(yargs, argv, convertOptions) {
 					binding += "-loader";
 				}
 				var rule = {
-					test: new RegExp("\\." + name.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, "\\$&") + "$"),
+					test: new RegExp("\\." + name.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, "\\$&") + "$"), // eslint-disable-line no-useless-escape
 					loader: binding
 				};
 				if(arg === "module-bind-pre") {
diff --git a/lib/MultiCompiler.js b/lib/MultiCompiler.js
@@ -46,8 +46,8 @@ module.exports = class MultiCompiler extends Tapable {
 	get outputPath() {
 		let commonPath = this.compilers[0].outputPath;
 		for(const compiler of this.compilers) {
-			while(compiler.outputPath.indexOf(commonPath) !== 0 && /[\/\\]/.test(commonPath)) {
-				commonPath = commonPath.replace(/[\/\\][^\/\\]*$/, "");
+			while(compiler.outputPath.indexOf(commonPath) !== 0 && /[/\\]/.test(commonPath)) {
+				commonPath = commonPath.replace(/[/\\][^/\\]*$/, "");
 			}
 		}
 
diff --git a/lib/Parser.js b/lib/Parser.js
@@ -1102,7 +1102,7 @@ class Parser extends Tapable {
 				result = this.applyPluginsBailResult1("call " + callee.identifier, expression);
 				if(result === true)
 					return;
-				let identifier = callee.identifier.replace(/\.[^\.]+$/, ".*");
+				let identifier = callee.identifier.replace(/\.[^.]+$/, ".*");
 				if(identifier !== callee.identifier) {
 					result = this.applyPluginsBailResult1("call " + identifier, expression);
 					if(result === true)
diff --git a/lib/Stats.js b/lib/Stats.js
@@ -108,7 +108,7 @@ class Stats {
 		const showPublicPath = optionOrLocalFallback(options.publicPath, !forToString);
 		const excludeModules = [].concat(optionOrFallback(options.exclude, [])).map(item => {
 			if(typeof item === "string") {
-				const regExp = new RegExp(`[\\\\/]${item.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, "\\$&")}([\\\\/]|$|!|\\?)`);
+				const regExp = new RegExp(`[\\\\/]${item.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, "\\$&")}([\\\\/]|$|!|\\?)`); // eslint-disable-line no-useless-escape
 				return ident => regExp.test(ident);
 			}
 			if(item && typeof item === "object" && typeof item.test === "function")
diff --git a/lib/Template.js b/lib/Template.js
@@ -28,7 +28,7 @@ module.exports = class Template extends Tapable {
 
 	static toPath(str) {
 		if(typeof str !== "string") return "";
-		return str.replace(/[^a-zA-Z0-9_!§$()=\-\^°]+/g, "-").replace(/^-|-$/, "");
+		return str.replace(/[^a-zA-Z0-9_!§$()=\-^°]+/g, "-").replace(/^-|-$/, "");
 	}
 
 	// map number to a single character a-z, A-Z or <_ + number> if number is too big
diff --git a/lib/dependencies/HarmonyCompatibilityDependency.js b/lib/dependencies/HarmonyCompatibilityDependency.js
@@ -21,7 +21,7 @@ HarmonyCompatibilityDependency.Template = class HarmonyExportDependencyTemplate
 		const usedExports = dep.originModule.usedExports;
 		if(usedExports && !Array.isArray(usedExports)) {
 			const exportName = dep.originModule.exportsArgument || "exports";
-			const content = `Object.defineProperty(${exportName}, \"__esModule\", { value: true });\n`;
+			const content = `Object.defineProperty(${exportName}, "__esModule", { value: true });\n`;
 			source.insert(-10, content);
 		}
 	}
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -60,8 +60,8 @@ The available options are:
 		 * that webpack will take care of loading this file.
 		 */
 		if(options.async && options.filename) {
-			throw new Error(`You can not specify a filename if you use the \"async\" option.
-You can however specify the name of the async chunk by passing the desired string as the \"async\" option.`);
+			throw new Error(`You can not specify a filename if you use the "async" option.
+You can however specify the name of the async chunk by passing the desired string as the "async" option.`);
 		}
 
 		/**
diff --git a/test/binCases/config-name/not-found/test.js b/test/binCases/config-name/not-found/test.js
@@ -3,6 +3,6 @@
 module.exports = function testAssertions(code, stdout, stderr) {
 	code.should.not.eql(0);
 	stdout.should.be.empty();
-	stderr[0].should.containEql("Configuration with name \'foo\' was not found.");
+	stderr[0].should.containEql("Configuration with name 'foo' was not found.");
 };
 
diff --git a/test/configCases/rule-set/custom/webpack.config.js b/test/configCases/rule-set/custom/webpack.config.js
@@ -7,9 +7,9 @@ module.exports = {
 					return {
 						loader: "./loader",
 						options: {
-							resource: data.resource.replace(/^.*[\\\/]/g, ""),
+							resource: data.resource.replace(/^.*[\\/]/g, ""),
 							resourceQuery: data.resourceQuery,
-							issuer: data.issuer.replace(/^.*[\\\/]/g, ""),
+							issuer: data.issuer.replace(/^.*[\\/]/g, ""),
 						}
 					};
 				}
diff --git a/test/statsCases/named-chunks-plugin-async/webpack.config.js b/test/statsCases/named-chunks-plugin-async/webpack.config.js
@@ -14,7 +14,7 @@ module.exports = {
 			}
 			const chunkModulesToName = (chunk) => chunk.mapModules((mod) => {
 				const rs = new RequestShortener(mod.context);
-				return rs.shorten(mod.request).replace(/[.\/\\]/g, "_");
+				return rs.shorten(mod.request).replace(/[./\\]/g, "_");
 			}).join("-");
 
 			if(chunk.getNumberOfModules() > 0) {

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ module.exports = function(yargs, argv, convertOptions) {`
`300`	`300`	`binding += "-loader";`
`301`	`301`	`}`
`302`	`302`	`var rule = {`
`303`		`- test: new RegExp("\\." + name.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\\|]/g, "\\$&") + "$"),`
	`303`	`+ test: new RegExp("\\." + name.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\\|]/g, "\\$&") + "$"), // eslint-disable-line no-useless-escape`
`304`	`304`	`loader: binding`
`305`	`305`	`};`
`306`	`306`	`if(arg === "module-bind-pre") {`
Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,8 @@ module.exports = class MultiCompiler extends Tapable {`
`46`	`46`	`get outputPath() {`
`47`	`47`	`let commonPath = this.compilers[0].outputPath;`
`48`	`48`	`for(const compiler of this.compilers) {`
`49`		`- while(compiler.outputPath.indexOf(commonPath) !== 0 && /[\/\\]/.test(commonPath)) {`
`50`		`- commonPath = commonPath.replace(/[\/\\][^\/\\]*$/, "");`
	`49`	`+ while(compiler.outputPath.indexOf(commonPath) !== 0 && /[/\\]/.test(commonPath)) {`
	`50`	`+ commonPath = commonPath.replace(/[/\\][^/\\]*$/, "");`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ class Stats {`
`108`	`108`	`const showPublicPath = optionOrLocalFallback(options.publicPath, !forToString);`
`109`	`109`	`const excludeModules = [].concat(optionOrFallback(options.exclude, [])).map(item => {`
`110`	`110`	`if(typeof item === "string") {`
`111`		- const regExp = new RegExp(`[\\\\/]${item.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\\|]/g, "\\$&")}([\\\\/]\|$\|!\|\\?)`);
	`111`	+ const regExp = new RegExp(`[\\\\/]${item.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\\|]/g, "\\$&")}([\\\\/]\|$\|!\|\\?)`); // eslint-disable-line no-useless-escape
`112`	`112`	`return ident => regExp.test(ident);`
`113`	`113`	`}`
`114`	`114`	`if(item && typeof item === "object" && typeof item.test === "function")`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ module.exports = class Template extends Tapable {`
`28`	`28`
`29`	`29`	`static toPath(str) {`
`30`	`30`	`if(typeof str !== "string") return "";`
`31`		`- return str.replace(/[^a-zA-Z0-9_!§$()=\-\^°]+/g, "-").replace(/^-\|-$/, "");`
	`31`	`+ return str.replace(/[^a-zA-Z0-9_!§$()=\-^°]+/g, "-").replace(/^-\|-$/, "");`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`// map number to a single character a-z, A-Z or <_ + number> if number is too big`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ HarmonyCompatibilityDependency.Template = class HarmonyExportDependencyTemplate`
`21`	`21`	`const usedExports = dep.originModule.usedExports;`
`22`	`22`	`if(usedExports && !Array.isArray(usedExports)) {`
`23`	`23`	`const exportName = dep.originModule.exportsArgument \|\| "exports";`
`24`		- const content = `Object.defineProperty(${exportName}, \"__esModule\", { value: true });\n`;
	`24`	+ const content = `Object.defineProperty(${exportName}, "__esModule", { value: true });\n`;
`25`	`25`	`source.insert(-10, content);`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@ module.exports = {`
`7`	`7`	`return {`
`8`	`8`	`loader: "./loader",`
`9`	`9`	`options: {`
`10`		`- resource: data.resource.replace(/^.*[\\\/]/g, ""),`
	`10`	`+ resource: data.resource.replace(/^.*[\\/]/g, ""),`
`11`	`11`	`resourceQuery: data.resourceQuery,`
`12`		`- issuer: data.issuer.replace(/^.*[\\\/]/g, ""),`
	`12`	`+ issuer: data.issuer.replace(/^.*[\\/]/g, ""),`
`13`	`13`	`}`
`14`	`14`	`};`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ module.exports = {`
`14`	`14`	`}`
`15`	`15`	`const chunkModulesToName = (chunk) => chunk.mapModules((mod) => {`
`16`	`16`	`const rs = new RequestShortener(mod.context);`
`17`		`- return rs.shorten(mod.request).replace(/[.\/\\]/g, "_");`
	`17`	`+ return rs.shorten(mod.request).replace(/[./\\]/g, "_");`
`18`	`18`	`}).join("-");`
`19`	`19`
`20`	`20`	`if(chunk.getNumberOfModules() > 0) {`