Improvement: add schema for profiling plugin options, remove todo item: abs path to false

EugeneHlushko · EugeneHlushko · commit 97cd2dde7055 · 2018-02-14T09:49:15.000+02:00
diff --git a/lib/debug/ProfilingPlugin.js b/lib/debug/ProfilingPlugin.js
@@ -1,5 +1,7 @@
 const fs = require("fs");
 const Trace = require("chrome-trace-event").Tracer;
+const validateOptions = require("schema-utils");
+const schema = require("../../schemas/plugins/debug/ProfilingPlugin.json");
 let inspector = undefined;
 
 try {
@@ -131,8 +133,6 @@ function createTrace(outPath) {
 }
 
 const pluginName = "ProfilingPlugin";
-const validateOptions = require("schema-utils");
-const schema = require("../../schemas/plugins/debug/ProfilingPlugin.json");
 
 class ProfilingPlugin {
 	constructor(opts) {
diff --git a/schemas/plugins/debug/ProfilingPlugin.json b/schemas/plugins/debug/ProfilingPlugin.json
@@ -6,7 +6,7 @@
     "outPath": {
       "description": "Path to the output file e.g. `profiling/events.json`. Defaults to `events.json`.",
       "type": "string",
-      "absolutePath": true,
+      "absolutePath": false,
       "minLength": 4
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`"outPath": {`
`7`	`7`	"description": "Path to the output file e.g. `profiling/events.json`. Defaults to `events.json`.",
`8`	`8`	`"type": "string",`
`9`		`- "absolutePath": true,`
	`9`	`+ "absolutePath": false,`
`10`	`10`	`"minLength": 4`
`11`	`11`	`}`
`12`	`12`	`}`