allow string in require.ensure

sokra · sokra · commit 9738b8a30ea6 · 2014-10-07T15:56:15.000+02:00
fixed webpack#500
diff --git a/lib/dependencies/RequireEnsureDependenciesBlockParserPlugin.js b/lib/dependencies/RequireEnsureDependenciesBlockParserPlugin.js
@@ -20,7 +20,7 @@ module.exports = AbstractPlugin.create({
 		case 2:
 			var dependencies = null;
 			var dependenciesExpr = this.evaluateExpression(expr.arguments[0]);
-			if(!dependenciesExpr.isArray()) return;
+			var dependenciesItems = dependenciesExpr.isArray() ? dependenciesExpr.items : [dependenciesExpr];
 			var fnExpressionArg = expr.arguments[1];
 			var fnExpression = getFunctionExpression(fnExpressionArg);
 
@@ -34,7 +34,7 @@ module.exports = AbstractPlugin.create({
 			try {
 				var failed = false;
 				this.inScope([], function() {
-					dependenciesExpr.items.forEach(function(ee) {
+					dependenciesItems.forEach(function(ee) {
 						if(ee.isString()) {
 							var edep = new RequireEnsureItemDependency(ee.string, ee.range);
 							edep.loc = dep.loc;
diff --git a/test/cases/parsing/chunks/index.js b/test/cases/parsing/chunks/index.js
@@ -12,4 +12,11 @@ it("should parse a bound function expression in require.ensure", function(done)
 		require("./file").should.be.eql("ok");
 		done();
 	}.bind(this));
+});
+
+it("should parse a string in require.ensure", function(done) {
+	require.ensure("./file", function(require) {
+		require("./file").should.be.eql("ok");
+		done();
+	});
 });
