stricter testing of hash and chunkhash interpolation

Travmatth · Travmatth · commit 905e3d530b5a · 2017-04-13T13:39:53.000-04:00
diff --git a/test/configCases/plugins/banner-plugin-hashing/index.js b/test/configCases/plugins/banner-plugin-hashing/index.js
@@ -15,21 +15,22 @@ var source = require("fs")
 	.slice(0,1)[0];
 
 const banner = parseBanner(source)
+const REGEXP_HASH = /^[A-Za-z0-9]{20}$/
 
 it("should interpolate file hash in bundle0 chunk", () => {
-	banner["hash"].should.not.equal("[hash]");
+	REGEXP_HASH.test(banner["hash"]).should.be.true;
 });
 
 it("should interpolate chunkHash in bundle0 chunk", () => {
-	banner["chunkhash"].should.not.equal("[chunkhash]");
+	REGEXP_HASH.test(banner["chunkhash"]).should.be.true;
 });
 
 it("should interpolate name in bundle0 chunk", () => {
-	banner["name"].should.not.equal("[name]");
+	banner["name"].should.equal("banner");
 });
 
 it("should interpolate extension in bundle0 chunk", () => {
-	banner["ext"].should.not.equal("[filebase]");
+	banner["basename"].should.equal("banner.js");
 });
 
 it("should interpolate extension in bundle0 chunk", () => {
diff --git a/test/configCases/plugins/banner-plugin-hashing/webpack.config.js b/test/configCases/plugins/banner-plugin-hashing/webpack.config.js
@@ -14,7 +14,7 @@ module.exports = {
 	},
 	plugins: [
 		new webpack.BannerPlugin({
-			banner: "hash:[hash], chunkhash:[chunkhash], name:[name], ext:[filebase], query:[query]"
+			banner: "hash:[hash], chunkhash:[chunkhash], name:[name], basename:[filebase], query:[query]"
 		})
 	]
 };

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ module.exports = {`
`14`	`14`	`},`
`15`	`15`	`plugins: [`
`16`	`16`	`new webpack.BannerPlugin({`
`17`		`- banner: "hash:[hash], chunkhash:[chunkhash], name:[name], ext:[filebase], query:[query]"`
	`17`	`+ banner: "hash:[hash], chunkhash:[chunkhash], name:[name], basename:[filebase], query:[query]"`
`18`	`18`	`})`
`19`	`19`	`]`
`20`	`20`	`};`