Merge pull request webpack#3856 from timse/minor-things

sokra · web-flow · commit 8bd27386dd39 · 2017-01-09T15:59:19.000+01:00
Minor things
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -5,7 +5,7 @@
 "use strict";
 
 const async = require("async");
-
+const crypto = require("crypto");
 const Tapable = require("tapable");
 const EntryModuleNotFoundError = require("./EntryModuleNotFoundError");
 const ModuleNotFoundError = require("./ModuleNotFoundError");
@@ -550,8 +550,6 @@ class Compilation extends Tapable {
 
 			const shouldRecord = self.applyPluginsBailResult("should-record") !== false;
 
-			self.sortItemsBeforeIds();
-
 			self.applyPlugins2("revive-modules", self.modules, self.records);
 			self.applyPlugins1("optimize-module-order", self.modules);
 			self.applyPlugins1("advanced-optimize-module-order", self.modules);
@@ -896,10 +894,6 @@ class Compilation extends Tapable {
 		});
 	}
 
-	sortItemsBeforeIds() {
-
-	}
-
 	sortItemsWithModuleIds() {
 		this.modules.sort(byId);
 		this.modules.forEach(module => module.sortItems());
@@ -955,7 +949,7 @@ class Compilation extends Tapable {
 		const hashFunction = outputOptions.hashFunction;
 		const hashDigest = outputOptions.hashDigest;
 		const hashDigestLength = outputOptions.hashDigestLength;
-		const hash = require("crypto").createHash(hashFunction);
+		const hash = crypto.createHash(hashFunction);
 		if(outputOptions.hashSalt)
 			hash.update(outputOptions.hashSalt);
 		this.mainTemplate.updateHash(hash);
@@ -975,7 +969,7 @@ class Compilation extends Tapable {
 		});
 		for(let i = 0; i < chunks.length; i++) {
 			chunk = chunks[i];
-			const chunkHash = require("crypto").createHash(hashFunction);
+			const chunkHash = crypto.createHash(hashFunction);
 			if(outputOptions.hashSalt)
 				hash.update(outputOptions.hashSalt);
 			chunk.updateHash(chunkHash);
@@ -998,7 +992,7 @@ class Compilation extends Tapable {
 		const hashFunction = outputOptions.hashFunction;
 		const hashDigest = outputOptions.hashDigest;
 		const hashDigestLength = outputOptions.hashDigestLength;
-		const hash = require("crypto").createHash(hashFunction);
+		const hash = crypto.createHash(hashFunction);
 		hash.update(this.fullHash);
 		hash.update(update);
 		this.fullHash = hash.digest(hashDigest);
