fix support for patterns in for in/of statements

sokra · sokra · commit 8a79c213e7eb · 2018-01-01T10:48:56.000+01:00
add test case
diff --git a/lib/Parser.js b/lib/Parser.js
@@ -908,30 +908,30 @@ class Parser extends Tapable {
 
 	prewalkForInStatement(statement) {
 		if(statement.left.type === "VariableDeclaration")
-			this.prewalkStatement(statement.left);
+			this.prewalkVariableDeclaration(statement.left);
 		this.prewalkStatement(statement.body);
 	}
 
 	walkForInStatement(statement) {
 		if(statement.left.type === "VariableDeclaration")
-			this.walkStatement(statement.left);
+			this.walkVariableDeclaration(statement.left);
 		else
-			this.walkExpression(statement.left);
+			this.walkPattern(statement.left);
 		this.walkExpression(statement.right);
 		this.walkStatement(statement.body);
 	}
 
 	prewalkForOfStatement(statement) {
 		if(statement.left.type === "VariableDeclaration")
-			this.prewalkStatement(statement.left);
+			this.prewalkVariableDeclaration(statement.left);
 		this.prewalkStatement(statement.body);
 	}
 
 	walkForOfStatement(statement) {
 		if(statement.left.type === "VariableDeclaration")
-			this.walkStatement(statement.left);
+			this.walkVariableDeclaration(statement.left);
 		else
-			this.walkExpression(statement.left);
+			this.walkPattern(statement.left);
 		this.walkExpression(statement.right);
 		this.walkStatement(statement.body);
 	}
diff --git a/test/cases/parsing/pattern-in-for/index.js b/test/cases/parsing/pattern-in-for/index.js
@@ -0,0 +1,15 @@
+it("should parse patterns in for in/of statements", () => {
+	var message;
+	for({ message = require("./module")} of [{}]) {
+		message.should.be.eql("ok");
+	}
+	for({ message = require("./module") } in { "string": "value" }) {
+		message.should.be.eql("ok");
+	}
+	for(var { value = require("./module")} of [{}]) {
+		value.should.be.eql("ok");
+	}
+	for(var { value = require("./module") } in { "string": "value" }) {
+		value.should.be.eql("ok");
+	}
+});
diff --git a/test/cases/parsing/pattern-in-for/module.js b/test/cases/parsing/pattern-in-for/module.js
@@ -0,0 +1 @@
+module.exports = "ok";
