Skip to content

Commit 84d1f66

Browse files
committed
refactor(ES6): migrating to () => {}
1 parent e075693 commit 84d1f66

1 file changed

Lines changed: 20 additions & 22 deletions

File tree

lib/DelegatedModuleFactoryPlugin.js

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -21,30 +21,28 @@ class DelegatedModuleFactoryPlugin {
2121
apply(normalModuleFactory) {
2222
const scope = this.options.scope;
2323
if(scope) {
24-
normalModuleFactory.plugin("factory", function(factory) {
25-
return function(data, callback) {
26-
const dependency = data.dependencies[0];
27-
const request = dependency.request;
28-
if(request && request.indexOf(scope + "/") === 0) {
29-
const innerRequest = "." + request.substr(scope.length);
30-
let resolved;
31-
if(innerRequest in this.options.content) {
32-
resolved = this.options.content[innerRequest];
33-
return callback(null, new DelegatedModule(this.options.source, resolved, this.options.type, innerRequest));
34-
}
35-
for(let i = 0; i < this.options.extensions.length; i++) {
36-
const requestPlusExt = innerRequest + this.options.extensions[i];
37-
if(requestPlusExt in this.options.content) {
38-
resolved = this.options.content[requestPlusExt];
39-
return callback(null, new DelegatedModule(this.options.source, resolved, this.options.type, requestPlusExt));
40-
}
24+
normalModuleFactory.plugin("factory", factory => (data, callback) => {
25+
const dependency = data.dependencies[0];
26+
const request = dependency.request;
27+
if(request && request.indexOf(scope + "/") === 0) {
28+
const innerRequest = "." + request.substr(scope.length);
29+
let resolved;
30+
if(innerRequest in this.options.content) {
31+
resolved = this.options.content[innerRequest];
32+
return callback(null, new DelegatedModule(this.options.source, resolved, this.options.type, innerRequest));
33+
}
34+
for(let i = 0; i < this.options.extensions.length; i++) {
35+
const requestPlusExt = innerRequest + this.options.extensions[i];
36+
if(requestPlusExt in this.options.content) {
37+
resolved = this.options.content[requestPlusExt];
38+
return callback(null, new DelegatedModule(this.options.source, resolved, this.options.type, requestPlusExt));
4139
}
4240
}
43-
return factory(data, callback);
44-
}.bind(this);
45-
}.bind(this));
41+
}
42+
return factory(data, callback);
43+
});
4644
} else {
47-
normalModuleFactory.plugin("module", function(module) {
45+
normalModuleFactory.plugin("module", module => {
4846
if(module.libIdent) {
4947
const request = module.libIdent(this.options);
5048
if(request && request in this.options.content) {
@@ -53,7 +51,7 @@ class DelegatedModuleFactoryPlugin {
5351
}
5452
}
5553
return module;
56-
}.bind(this));
54+
});
5755
}
5856
}
5957
}

0 commit comments

Comments
 (0)