fix contrains checks, might get obsolete in the future

timse · timse · commit 7e0a6ca28759 · 2017-06-24T11:39:46.000+10:00
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -448,16 +448,19 @@ class Chunk {
 
 	checkConstraints() {
 		const chunk = this;
-		chunk._chunks.forEach((child, idx) => {
-			if(Array.from(chunk._chunks).indexOf(child) !== idx)
+		const chunks = Array.from(chunk._chunks);
+		chunks.forEach((child, idx) => {
+			if(chunks.indexOf(child) !== idx)
 				throw new Error(`checkConstraints: duplicate child in chunk ${chunk.debugId} ${child.debugId}`);
 			if(child.parents.indexOf(chunk) < 0)
 				throw new Error(`checkConstraints: child missing parent ${chunk.debugId} -> ${child.debugId}`);
 		});
 		chunk.parents.forEach((parentChunk, idx) => {
 			if(chunk.parents.indexOf(parentChunk) !== idx)
 				throw new Error(`checkConstraints: duplicate parent in chunk ${chunk.debugId} ${parentChunk.debugId}`);
-			if(parentChunk._chunks.indexOf(chunk) < 0)
+
+			const chunks = Array.from(parentChunk._chunks);
+			if(chunks.indexOf(chunk) < 0)
 				throw new Error(`checkConstraints: parent missing child ${parentChunk.debugId} <- ${chunk.debugId}`);
 		});
 	}
diff --git a/test/Chunk.test.js b/test/Chunk.test.js
@@ -128,7 +128,7 @@ describe("Chunk", () => {
 		});
 		describe("and the chunk does contain this module", function() {
 			beforeEach(function() {
-				ChunkInstance.chunks = [chunk];
+				ChunkInstance._chunks = new Set([chunk]);
 			});
 			it("calls module.removeChunk with itself and returns true", function() {
 				ChunkInstance.removeChunk(chunk).should.eql(true);
