update ExternalModule hash with optional flag

dtinth · dtinth · commit 79cf75a8b5ab · 2017-09-18T14:48:11.000+07:00
diff --git a/lib/ExternalModule.js b/lib/ExternalModule.js
@@ -120,6 +120,7 @@ class ExternalModule extends Module {
 	updateHash(hash) {
 		hash.update(this.type);
 		hash.update(JSON.stringify(this.request));
+		hash.update(JSON.stringify(this.optional));
 		super.updateHash(hash);
 	}
 }
diff --git a/test/ExternalModule.test.js b/test/ExternalModule.test.js
@@ -323,6 +323,7 @@ module.exports = some/request;`;
 					hashedText += text;
 				}
 			};
+			externalModule.optional = true;
 			externalModule.updateHash(hash);
 		});
 		it("updates hash with request", function() {
@@ -331,5 +332,8 @@ module.exports = some/request;`;
 		it("updates hash with type", function() {
 			hashedText.should.containEql("some-type");
 		});
+		it("updates hash with optional flag", function() {
+			hashedText.should.containEql("true");
+		});
 	});
 });
diff --git a/test/statsCases/external/expected.txt b/test/statsCases/external/expected.txt
@@ -1,4 +1,4 @@
-Hash: 7861295d7291830ba01f
+Hash: e500321cbaac14df7284
 Time: Xms
   Asset     Size  Chunks             Chunk Names
 main.js  2.61 kB       0  [emitted]  main

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,7 @@ class ExternalModule extends Module {`
`120`	`120`	`updateHash(hash) {`
`121`	`121`	`hash.update(this.type);`
`122`	`122`	`hash.update(JSON.stringify(this.request));`
	`123`	`+ hash.update(JSON.stringify(this.optional));`
`123`	`124`	`super.updateHash(hash);`
`124`	`125`	`}`
`125`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-Hash: 7861295d7291830ba01f`
	`1`	`+Hash: e500321cbaac14df7284`
`2`	`2`	`Time: Xms`
`3`	`3`	`Asset Size Chunks Chunk Names`
`4`	`4`	`main.js 2.61 kB 0 [emitted] main`