changed example to made coverage pass. It also seemed like the common functionality may not be working correctly

jerairrest · jerairrest · commit 77705e106c94 · 2017-01-23T22:59:17.000-06:00
diff --git a/examples/move-to-parent/page.js b/examples/move-to-parent/page.js
diff --git a/examples/move-to-parent/pageA.js b/examples/move-to-parent/pageA.js
@@ -0,0 +1 @@
+require(["./a"]);
diff --git a/examples/move-to-parent/pageB.js b/examples/move-to-parent/pageB.js
@@ -0,0 +1 @@
+require(["./a", "./b"]);
diff --git a/examples/move-to-parent/pageC.js b/examples/move-to-parent/pageC.js
@@ -0,0 +1,2 @@
+require(["./a", "./b", "./c"]);
+
diff --git a/examples/move-to-parent/pageD.js b/examples/move-to-parent/pageD.js
@@ -0,0 +1 @@
+require(["./a", "./b", "./c", "./d"]);
diff --git a/examples/move-to-parent/webpack.config.js b/examples/move-to-parent/webpack.config.js
@@ -2,18 +2,18 @@ var path = require("path");
 var CommonsChunkPlugin = require("../../lib/optimize/CommonsChunkPlugin");
 module.exports = {
 	entry: {
-		pageA: "./page?A",
-		pageB: "./page?B",
-		pageC: "./page?C",
-		pageD: "./page?D"
+		pageA: "./pageA",
+		pageB: "./pageB",
+		pageC: "./pageC",
+		pageD: "./pageD"
 	},
 	output: {
 		path: path.join(__dirname, "js"),
 		filename: "[name].bundle.js",
 		chunkFilename: "[id].chunk.js"
 	},
 	plugins: [
-		// check for common modules in children of pageA and move them to the parent
+		//check for common modules in children of pageA and move them to the parent
 		new CommonsChunkPlugin({
 			name: "pageA",
 			children: true
@@ -32,7 +32,7 @@ module.exports = {
 			children: true,
 			minChunks: function(module, count) {
 				// move only module "b"
-				return /b\.js$/.test(module.identifier());
+				return !/b\.js$/.test(module.identifier());
 			}
 		})
 	]

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+require(["./a", "./b", "./c"]);`
	`2`	`+`