Add color information to stats based on bundle size

vigneshshanmugam · sokra · commit 7736ebe36778 · 2016-12-07T17:21:20.000+01:00
diff --git a/lib/Stats.js b/lib/Stats.js
@@ -324,6 +324,9 @@ Stats.prototype.toJson = function toJson(options, forToString) {
 			return obj;
 		});
 	}
+	if(showPerformance) {
+		obj.performance = compilation.options.performance;
+	}
 	return obj;
 };
 
@@ -395,7 +398,7 @@ Stats.jsonToString = function jsonToString(obj, useColors) {
 		buf.push("\n");
 	}
 
-	function table(array, formats, align, splitter) {
+	function table(array, align, splitter) {
 		var row;
 		var rows = array.length;
 		var col;
@@ -406,16 +409,16 @@ Stats.jsonToString = function jsonToString(obj, useColors) {
 			colSizes[col] = 3;
 		for(row = 0; row < rows; row++) {
 			for(col = 0; col < cols; col++) {
-				value = array[row][col] + "";
+				value = array[row][col].value + "";
 				if(value.length > colSizes[col]) {
 					colSizes[col] = value.length;
 				}
 			}
 		}
 		for(row = 0; row < rows; row++) {
 			for(col = 0; col < cols; col++) {
-				var format = row === 0 ? colors.bold : formats[col];
-				value = array[row][col] + "";
+				var format = row === 0 ? colors.bold : array[row][col].color;
+				value = array[row][col].value + "";
 				var l = value.length;
 				if(align[col] === "l")
 					format(value);
@@ -440,6 +443,19 @@ Stats.jsonToString = function jsonToString(obj, useColors) {
 			.toPrecision(3) + " " + abbreviations[index];
 	}
 
+	function isHugeBundle(assetSize) {
+		var sizeLimit = obj.performance.maxAssetSize;
+		sizeLimit = sizeLimit * 1024;
+		return sizeLimit < assetSize;
+	}
+
+	function getAssetColor(asset, defaultColor) {
+		if(isHugeBundle(asset.size)) {
+			return colors.yellow;
+		}
+		return defaultColor;
+	}
+
 	if(obj.hash) {
 		colors.normal("Hash: ");
 		colors.bold(obj.hash);
@@ -466,15 +482,20 @@ Stats.jsonToString = function jsonToString(obj, useColors) {
 			["Asset", "Size", "Chunks", "", "Chunk Names"]
 		];
 		obj.assets.forEach(function(asset) {
-			t.push([
-				asset.name,
-				formatSize(asset.size),
-				asset.chunks.join(", "),
-				asset.emitted ? "[emitted]" : "",
-				asset.chunkNames.join(", ")
+			t.push([{
+				value: asset.name, color: getAssetColor(asset, colors.green)
+			}, {
+				value: formatSize(asset.size), color: getAssetColor(asset, colors.normal)
+			}, {
+				value: asset.chunks.join(", "), color: colors.bold
+			}, {
+				value: asset.emitted ? "[emitted]" : "", color: colors.green
+			}, {
+				value: asset.chunkNames.join(", "), color: colors.normal
+			}
 			]);
 		});
-		table(t, [colors.green, colors.normal, colors.bold, colors.green, colors.normal], "rrrll");
+		table(t, "rrrll");
 	}
 	if(obj.entrypoints) {
 		Object.keys(obj.entrypoints).forEach(function(name) {
diff --git a/lib/performance/EmittedAssetSizeLimitPlugin.js b/lib/performance/EmittedAssetSizeLimitPlugin.js
@@ -15,7 +15,6 @@ function normalizeAndCompare(sizeLimit, assetSize) {
 	// sizeLimit=maxAssetSize is always expressed in kB
 	// assetSize is expressed in byte size
 	sizeLimit = sizeLimit * 1024;
-	console.log(sizeLimit, assetSize);
 	return sizeLimit < assetSize;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ function normalizeAndCompare(sizeLimit, assetSize) {`
`15`	`15`	`// sizeLimit=maxAssetSize is always expressed in kB`
`16`	`16`	`// assetSize is expressed in byte size`
`17`	`17`	`sizeLimit = sizeLimit * 1024;`
`18`		`- console.log(sizeLimit, assetSize);`
`19`	`18`	`return sizeLimit < assetSize;`
`20`	`19`	`}`
`21`	`20`