refactor(ES6): upgrade MinChunkSizePlugin to ES6 (webpack#3757)

shubheksha · TheLarkInn · commit 70bf6c281710 · 2017-01-04T23:42:36.000-06:00
* refactor(ES6): upgrade MergeDuplicateChunksPlugin to ES6
diff --git a/lib/optimize/MergeDuplicateChunksPlugin.js b/lib/optimize/MergeDuplicateChunksPlugin.js
@@ -2,29 +2,32 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-function MergeDuplicateChunksPlugin() {}
-module.exports = MergeDuplicateChunksPlugin;
+"use strict";
 
 function getChunkIdentifier(chunk) {
-	return chunk.modules.map(function(m) {
+	return chunk.modules.map((m) => {
 		return m.identifier();
 	}).sort().join(", ");
 }
 
-MergeDuplicateChunksPlugin.prototype.apply = function(compiler) {
-	compiler.plugin("compilation", function(compilation) {
-		compilation.plugin("optimize-chunks-basic", function(chunks) {
-			var map = {};
-			chunks.slice().forEach(function(chunk) {
-				if(chunk.hasRuntime() || chunk.hasEntryModule()) return;
-				var ident = getChunkIdentifier(chunk);
-				if(map[ident]) {
-					if(map[ident].integrate(chunk, "duplicate"))
-						chunks.splice(chunks.indexOf(chunk), 1);
-					return;
-				}
-				map[ident] = chunk;
+class MergeDuplicateChunksPlugin {
+
+	apply(compiler) {
+		compiler.plugin("compilation", (compilation) => {
+			compilation.plugin("optimize-chunks-basic", (chunks) => {
+				const map = {};
+				chunks.slice().forEach((chunk) => {
+					if(chunk.hasRuntime() || chunk.hasEntryModule()) return;
+					const ident = getChunkIdentifier(chunk);
+					if(map[ident]) {
+						if(map[ident].integrate(chunk, "duplicate"))
+							chunks.splice(chunks.indexOf(chunk), 1);
+						return;
+					}
+					map[ident] = chunk;
+				});
 			});
 		});
-	});
-};
+	}
+}
+module.exports = MergeDuplicateChunksPlugin;
diff --git a/lib/optimize/MinChunkSizePlugin.js b/lib/optimize/MinChunkSizePlugin.js
@@ -2,60 +2,64 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-function MinChunkSizePlugin(options) {
-	if(typeof options !== "object" || Array.isArray(options)) {
-		throw new Error("Argument should be an options object.\nFor more info on options, see https://webpack.github.io/docs/list-of-plugins.html");
+"use strict";
+
+class MinChunkSizePlugin {
+	constructor(options) {
+		if(typeof options !== "object" || Array.isArray(options)) {
+			throw new Error("Argument should be an options object.\nFor more info on options, see https://webpack.github.io/docs/list-of-plugins.html");
+		}
+		this.options = options;
 	}
-	this.options = options;
-}
-module.exports = MinChunkSizePlugin;
 
-MinChunkSizePlugin.prototype.apply = function(compiler) {
-	var options = this.options;
-	var minChunkSize = options.minChunkSize;
-	compiler.plugin("compilation", function(compilation) {
-		compilation.plugin("optimize-chunks-advanced", function(chunks) {
-
-			var combinations = [];
-			chunks.forEach(function(a, idx) {
-				for(var i = 0; i < idx; i++) {
-					var b = chunks[i];
-					combinations.push([b, a]);
-				}
-			});
+	apply(compiler) {
+		const options = this.options;
+		const minChunkSize = options.minChunkSize;
+		compiler.plugin("compilation", (compilation) => {
+			compilation.plugin("optimize-chunks-advanced", (chunks) => {
 
-			var equalOptions = {
-				chunkOverhead: 1,
-				entryChunkMultiplicator: 1
-			};
-			combinations = combinations.filter(function(pair) {
-				return pair[0].size(equalOptions) < minChunkSize || pair[1].size(equalOptions) < minChunkSize;
-			});
+				let combinations = [];
+				chunks.forEach((a, idx) => {
+					for(let i = 0; i < idx; i++) {
+						const b = chunks[i];
+						combinations.push([b, a]);
+					}
+				});
 
-			combinations.forEach(function(pair) {
-				var a = pair[0].size(options);
-				var b = pair[1].size(options);
-				var ab = pair[0].integratedSize(pair[1], options);
-				pair.unshift(a + b - ab, ab);
-			});
+				const equalOptions = {
+					chunkOverhead: 1,
+					entryChunkMultiplicator: 1
+				};
+				combinations = combinations.filter((pair) => {
+					return pair[0].size(equalOptions) < minChunkSize || pair[1].size(equalOptions) < minChunkSize;
+				});
 
-			combinations = combinations.filter(function(pair) {
-				return pair[1] !== false;
-			});
+				combinations.forEach((pair) => {
+					const a = pair[0].size(options);
+					const b = pair[1].size(options);
+					const ab = pair[0].integratedSize(pair[1], options);
+					pair.unshift(a + b - ab, ab);
+				});
 
-			if(combinations.length === 0) return;
+				combinations = combinations.filter((pair) => {
+					return pair[1] !== false;
+				});
 
-			combinations.sort(function(a, b) {
-				var diff = b[0] - a[0];
-				if(diff !== 0) return diff;
-				return a[1] - b[1];
-			});
+				if(combinations.length === 0) return;
+
+				combinations.sort((a, b) => {
+					const diff = b[0] - a[0];
+					if(diff !== 0) return diff;
+					return a[1] - b[1];
+				});
 
-			var pair = combinations[0];
+				const pair = combinations[0];
 
-			pair[2].integrate(pair[3], "min-size");
-			chunks.splice(chunks.indexOf(pair[3]), 1);
-			return true;
+				pair[2].integrate(pair[3], "min-size");
+				chunks.splice(chunks.indexOf(pair[3]), 1);
+				return true;
+			});
 		});
-	});
-};
+	}
+}
+module.exports = MinChunkSizePlugin;
