feat(ruleSet): show context when exclude holds undefined

GiuseppePiscopo · GiuseppePiscopo · commit 6dd2863899f6 · 2016-10-22T20:20:22.000+02:00
diff --git a/lib/RuleSet.js b/lib/RuleSet.js
@@ -51,7 +51,7 @@
 <condition>: { and: [<condition>] }
 <condition>: { or: [<condition>] }
 <condition>: { not: [<condition>] }
-<condition>: { test: <condition>, include: <condition>, exclude: <codition> }
+<condition>: { test: <condition>, include: <condition>, exclude: <condition> }
 
 
 normalized:
@@ -109,11 +109,20 @@ RuleSet.normalizeRule = function(rule) {
 
 	if(rule.test || rule.include || rule.exclude) {
 		checkResourceSource("test + include + exclude");
-		newRule.resource = RuleSet.normalizeCondition({
+		var condition = {
 			test: rule.test,
 			include: rule.include,
 			exclude: rule.exclude
-		});
+		};
+		try {
+			newRule.resource = RuleSet.normalizeCondition(condition);
+		} catch (error) {
+			var conditionAsText = JSON.stringify(condition, function(key, value) {
+				return (value === undefined) ? "undefined" : value;
+			}, 2)
+			var message = error.message + " in " + conditionAsText;
+			throw new Error(message);
+		}
 	}
 
 	if(rule.resource) {
diff --git a/test/RuleSet.test.js b/test/RuleSet.test.js
@@ -268,4 +268,29 @@ describe("RuleSet", function() {
 			(match(loader, 'style.css')).should.eql(['css']);
 		}, /No loader specified/)
 	});
+	it('should throw with context if exclude array holds an undefined item', function() {
+		should.throws(function() {
+			var loader = new RuleSet([{
+				test: /\.css$/,
+				loader: 'css',
+				include: [
+					'src',
+				],
+				exclude: [
+					'node_modules',
+					undefined,
+				],
+			}]);
+			(match(loader, 'style.css')).should.eql(['css']);
+		}, function(err) {
+			if (/Expected condition but got falsy value/.test(err)
+				&& /test/.test(err)
+				&& /include/.test(err)
+				&& /exclude/.test(err)
+				&& /node_modules/.test(err)
+				&& /undefined/.test(err)) {
+				return true;
+			}
+		})
+	});
 });
