remove ordering in ModuleConcatenationPlugin

sokra · sokra · commit 6607cfa4bdd7 · 2017-08-07T20:33:47.000+02:00
diff --git a/lib/optimize/ModuleConcatenationPlugin.js b/lib/optimize/ModuleConcatenationPlugin.js
@@ -136,9 +136,7 @@ class ModuleConcatenationPlugin {
 				for(const concatConfiguration of concatConfigurations) {
 					if(usedModules.has(concatConfiguration.rootModule))
 						continue;
-					const orderedModules = new Set();
-					this.addInOrder(concatConfiguration.rootModule, concatConfiguration.modules, orderedModules);
-					const newModule = new ConcatenatedModule(concatConfiguration.rootModule, Array.from(orderedModules));
+					const newModule = new ConcatenatedModule(concatConfiguration.rootModule, Array.from(concatConfiguration.modules));
 					concatConfiguration.sortWarnings();
 					for(const warning of concatConfiguration.warnings) {
 						newModule.optimizationBailout.push((requestShortener) => {
@@ -151,7 +149,7 @@ class ModuleConcatenationPlugin {
 						});
 					}
 					const chunks = concatConfiguration.rootModule.getChunks();
-					for(const m of orderedModules) {
+					for(const m of concatConfiguration.modules) {
 						usedModules.add(m);
 						chunks.forEach(chunk => chunk.removeModule(m));
 					}
@@ -247,16 +245,6 @@ class ModuleConcatenationPlugin {
 		config.set(testConfig);
 		return null;
 	}
-
-	addInOrder(module, unorderedSet, orderedSet) {
-		if(orderedSet.has(module)) return;
-		if(!unorderedSet.has(module)) return;
-		orderedSet.add(module);
-		for(const imp of this.getImports(module))
-			this.addInOrder(imp, unorderedSet, orderedSet);
-		orderedSet.delete(module);
-		orderedSet.add(module);
-	}
 }
 
 class ConcatConfiguration {
