apply review feedback

timse · timse · commit 61ce0f79c1eb · 2017-02-22T00:13:21.000+11:00
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -64,7 +64,12 @@ The available options are:
 You can however specify the name of the async chunk by passing the desired string as the \"async\" option.`);
 		}
 
-		const chunkNames = options.name ? [options.name] : options.names;
+		/**
+		 * Make sure this is either an array or undefined.
+		 * "name" can be a string and
+		 * "names" a string or an array
+		 */
+		const chunkNames = options.name || options.names ? [].concat(options.name || options.names) : undefined;
 		return {
 			chunkNames: chunkNames,
 			filenameTemplate: options.filename,
@@ -172,16 +177,18 @@ You can however specify the name of the async chunk by passing the desired strin
 		// we have specified chunk names
 		if(chunkNames) {
 			// map chunks by chunkName for quick access
-			const optimizedChunkMap = allChunks.reduce((map, chunk) => {
-				map.set(chunk.name, chunk);
+			const allChunksNameMap = allChunks.reduce((map, chunk) => {
+				if(chunk.name) {
+					map.set(chunk.name, chunk);
+				}
 				return map;
 			}, new Map());
 
 			// Ensure we have a chunk per specified chunk name.
 			// Reuse existing chunks if possible
 			return chunkNames.map(chunkName => {
-				if(optimizedChunkMap.has(chunkName)) {
-					return optimizedChunkMap.get(chunkName);
+				if(allChunksNameMap.has(chunkName)) {
+					return allChunksNameMap.get(chunkName);
 				}
 				// add the filtered chunks to the compilation
 				return compilation.addChunk(chunkName);
