refactor(ES6): upgrade RemoveParentModulesPlugin to ES6 (webpack#3731)

shubheksha · TheLarkInn · commit 61251de9c01a · 2017-01-04T12:44:01.000-06:00
diff --git a/lib/optimize/RemoveParentModulesPlugin.js b/lib/optimize/RemoveParentModulesPlugin.js
@@ -2,9 +2,11 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+"use strict";
+
 function chunkContainsModule(chunk, module) {
-	var chunks = module.chunks;
-	var modules = chunk.modules;
+	const chunks = module.chunks;
+	const modules = chunk.modules;
 	if(chunks.length < modules.length) {
 		return chunks.indexOf(chunk) >= 0;
 	} else {
@@ -15,35 +17,35 @@ function chunkContainsModule(chunk, module) {
 function hasModule(chunk, module, checkedChunks) {
 	if(chunkContainsModule(chunk, module)) return [chunk];
 	if(chunk.parents.length === 0) return false;
-	return allHaveModule(chunk.parents.filter(function(c) {
+	return allHaveModule(chunk.parents.filter((c) => {
 		return checkedChunks.indexOf(c) < 0;
 	}), module, checkedChunks);
 }
 
 function allHaveModule(someChunks, module, checkedChunks) {
 	if(!checkedChunks) checkedChunks = [];
-	var chunks = [];
+	let chunks = [];
 	for(var i = 0; i < someChunks.length; i++) {
 		checkedChunks.push(someChunks[i]);
-		var subChunks = hasModule(someChunks[i], module, checkedChunks);
+		const subChunks = hasModule(someChunks[i], module, checkedChunks);
 		if(!subChunks) return false;
 		addToSet(chunks, subChunks);
 	}
 	return chunks;
 }
 
 function addToSet(set, items) {
-	items.forEach(function(item) {
+	items.forEach((item) => {
 		if(set.indexOf(item) < 0)
 			set.push(item);
 	});
 }
 
 function debugIds(chunks) {
-	var list = chunks.map(function(chunk) {
+	const list = chunks.map((chunk) => {
 		return chunk.debugId;
 	});
-	var debugIdMissing = list.some(function(dId) {
+	const debugIdMissing = list.some((dId) => {
 		return typeof dId !== "number";
 	});
 	if(debugIdMissing)
@@ -52,29 +54,29 @@ function debugIds(chunks) {
 	return list.join(",");
 }
 
-function RemoveParentModulesPlugin() {}
-module.exports = RemoveParentModulesPlugin;
-
-RemoveParentModulesPlugin.prototype.apply = function(compiler) {
-	compiler.plugin("compilation", function(compilation) {
-		compilation.plugin(["optimize-chunks-basic", "optimize-extracted-chunks-basic"], function(chunks) {
-			chunks.forEach(function(chunk) {
-				var cache = {};
-				chunk.modules.slice().forEach(function(module) {
-					if(chunk.parents.length === 0) return;
-					var dId = "$" + debugIds(module.chunks);
-					var parentChunksWithModule;
-					if((dId in cache) && dId !== "$no") {
-						parentChunksWithModule = cache[dId];
-					} else {
-						parentChunksWithModule = cache[dId] = allHaveModule(chunk.parents, module);
-					}
-					if(parentChunksWithModule) {
-						module.rewriteChunkInReasons(chunk, parentChunksWithModule);
-						chunk.removeModule(module);
-					}
+class RemoveParentModulesPlugin {
+	apply(compiler) {
+		compiler.plugin("compilation", (compilation) => {
+			compilation.plugin(["optimize-chunks-basic", "optimize-extracted-chunks-basic"], (chunks) => {
+				chunks.forEach((chunk) => {
+					const cache = {};
+					chunk.modules.slice().forEach((module) => {
+						if(chunk.parents.length === 0) return;
+						const dId = "$" + debugIds(module.chunks);
+						let parentChunksWithModule;
+						if((dId in cache) && dId !== "$no") {
+							parentChunksWithModule = cache[dId];
+						} else {
+							parentChunksWithModule = cache[dId] = allHaveModule(chunk.parents, module);
+						}
+						if(parentChunksWithModule) {
+							module.rewriteChunkInReasons(chunk, parentChunksWithModule);
+							chunk.removeModule(module);
+						}
+					});
 				});
 			});
 		});
-	});
-};
+	}
+}
+module.exports = RemoveParentModulesPlugin;
