Support UglifyJsPlugin with no arguments in CLI --plugin

cletusw · sokra · commit 5f4481940b8b · 2017-01-11T12:20:59.000+01:00
UglifyJsPlugin checks `typeof options !== "object"`, which doesn't work as expected with `null` since its type is `"object"`. https://github.com/webpack/webpack/blob/a1dca894d9a04f55529e4b7c44dcabe2c1b439a1/lib/optimize/UglifyJsPlugin.js#L16 See webpack@48e17ab#commitcomment-20424582
diff --git a/bin/convert-argv.js b/bin/convert-argv.js
@@ -227,7 +227,7 @@ module.exports = function(yargs, argv, convertOptions) {
 
 		function loadPlugin(name) {
 			var loadUtils = require("loader-utils");
-			var args = null;
+			var args;
 			try {
 				var p = name && name.indexOf("?");
 				if(p > -1) {
diff --git a/test/binCases/plugins/uglifyjsplugin-empty-args/index.js b/test/binCases/plugins/uglifyjsplugin-empty-args/index.js
@@ -0,0 +1 @@
+module.exports = "foo";
diff --git a/test/binCases/plugins/uglifyjsplugin-empty-args/test.js b/test/binCases/plugins/uglifyjsplugin-empty-args/test.js
@@ -0,0 +1,15 @@
+"use strict";
+
+module.exports = function testAssertions(code, stdout, stderr) {
+  code.should.be.exactly(0);
+
+  stdout.should.be.ok();
+  stdout[3].should.containEql("Hash: ");
+  stdout[4].should.containEql("Version: ");
+  stdout[5].should.containEql("Time: ");
+  stdout[7].should.containEql("null.js");
+  stdout[8].should.containEql("./index.js");
+  stdout[8].should.containEql("[built]");
+
+  stderr.should.be.empty();
+}
diff --git a/test/binCases/plugins/uglifyjsplugin-empty-args/test.opts b/test/binCases/plugins/uglifyjsplugin-empty-args/test.opts
@@ -0,0 +1 @@
+--plugin webpack/lib/optimize/UglifyJsPlugin
diff --git a/test/binCases/plugins/uglifyjsplugin-empty-args/webpack.config.js b/test/binCases/plugins/uglifyjsplugin-empty-args/webpack.config.js
@@ -0,0 +1,5 @@
+var path = require("path");
+
+module.exports = {
+  entry: path.resolve(__dirname, "./index"),
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+--plugin webpack/lib/optimize/UglifyJsPlugin`