feat(defaults): add fixed defaults

TheLarkInn · TheLarkInn · commit 5e8700f5c509 · 2017-12-18T12:18:07.000-08:00
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -4,12 +4,18 @@
 */
 "use strict";
 
+const path = require("path");
+
 const OptionsDefaulter = require("./OptionsDefaulter");
 const Template = require("./Template");
 
 class WebpackOptionsDefaulter extends OptionsDefaulter {
 	constructor() {
 		super();
+
+		this.set("entry", "./src");
+		this.set("mode", "production");
+
 		this.set("devtool", "make", options => options.mode === "development" ? "eval" : false);
 		this.set("cache", "make", options => options.mode === "development");
 
@@ -57,6 +63,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 				return Object.assign({}, value);
 			}
 		});
+
 		this.set("output.filename", "[name].js");
 		this.set("output.chunkFilename", "make", (options) => {
 			const filename = options.output.filename;
@@ -81,7 +88,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 			return options.output.library || "";
 		});
 		this.set("output.libraryTarget", "var");
-		this.set("output.path", process.cwd());
+		this.set("output.path", path.join(process.cwd(), "dist"));
 		this.set("output.pathinfo", "make", options => options.mode === "development");
 		this.set("output.sourceMapFilename", "[file].map[query]");
 		this.set("output.hotUpdateChunkFilename", "[id].[hash].hot-update.js");
diff --git a/schemas/WebpackOptions.json b/schemas/WebpackOptions.json
@@ -1685,8 +1685,5 @@
       "type": "object"
     }
   },
-  "required": [
-    "entry"
-  ],
   "type": "object"
 }
diff --git a/test/Compiler-caching.test.js b/test/Compiler-caching.test.js
@@ -15,6 +15,7 @@ describe("Compiler (caching)", function() {
 		options = new WebpackOptionsDefaulter().process(options);
 		options.cache = true;
 		options.entry = entry;
+		options.optimization.minimize = false;
 		options.context = path.join(__dirname, "fixtures");
 		options.output.path = "/";
 		options.output.filename = "bundle.js";
diff --git a/test/Errors.test.js b/test/Errors.test.js
@@ -97,20 +97,6 @@ describe("Errors", () => {
 			done();
 		});
 	});
-	it("should warn when not using mode", (done) => {
-		getErrors({
-			entry: "./entry-point",
-		}, (errors, warnings) => {
-			errors.length.should.be.eql(0);
-			warnings.length.should.be.eql(1);
-			let lines = warnings[0].split("\n");
-			lines[0].should.match(/configuration/);
-			lines[1].should.match(/mode/);
-			lines[1].should.match(/development/);
-			lines[1].should.match(/production/);
-			done();
-		});
-	});
 	it("should not warn if the NoEmitOnErrorsPlugin is used over the NoErrorsPlugin", (done) => {
 		getErrors({
 			mode: "production",
diff --git a/test/Validation.test.js b/test/Validation.test.js
@@ -18,14 +18,6 @@ describe("Validation", () => {
 		message: [
 			" - configuration should be an object."
 		]
-	}, {
-		name: "empty configuration",
-		config: {},
-		message: [
-			" - configuration misses the property 'entry'.",
-			"   object { <key>: non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function",
-			"   -> The entry point(s) of the compilation."
-		]
 	}, {
 		name: "empty entry string",
 		config: {
@@ -185,7 +177,7 @@ describe("Validation", () => {
 		},
 		message: [
 			" - configuration has an unknown property 'postcss'. These properties are valid:",
-			"   object { mode?, amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, " +
+			"   object { mode?, amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry?, externals?, " +
 			"loader?, module?, name?, node?, output?, optimization?, parallelism?, performance?, plugins?, profile?, recordsInputPath?, " +
 			"recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }",
 			"   For typos: please correct them.",

Original file line number	Diff line number	Diff line change
`@@ -1685,8 +1685,5 @@`
`1685`	`1685`	`"type": "object"`
`1686`	`1686`	`}`
`1687`	`1687`	`},`
`1688`		`- "required": [`
`1689`		`- "entry"`
`1690`		`- ],`
`1691`	`1688`	`"type": "object"`
`1692`	`1689`	`}`