fix: cli --watch-poll not accept number correctly

visig9 · visig9 · commit 5a2f7ead8229 · 2017-08-15T09:52:01.000+08:00
The document say "--watch-poll" option can determine "The polling
interval for watching (also enable polling)". But the previous
implement only accept boolean value and no way to set the interval.

This patch try to fix this problem by allow number input like this:
"--watch-poll=100".

This patch also try to keep the original behavior not be changed as much
as possible. So "--watch-poll" and "--watch-poll=true" are still
acceptable (enable the polling ability).

But still has one incompatible change: original "--watch-poll=" mean
disable polling but after this fix it mean enable polling. It's due to
yargs can not differentiate the different between "--watch-poll" and
"--watch-poll=" when using string type option. So no way to workaround
for this problem.
diff --git a/bin/config-yargs.js b/bin/config-yargs.js
@@ -172,7 +172,7 @@ module.exports = function(yargs) {
 				requiresArg: true
 			},
 			"watch-poll": {
-				type: "boolean",
+				type: "string",
 				describe: "The polling interval for watching (also enable polling)",
 				group: ADVANCED_GROUP
 			},
diff --git a/bin/convert-argv.js b/bin/convert-argv.js
@@ -166,12 +166,12 @@ module.exports = function(yargs, argv, convertOptions) {
 			options.watchOptions.aggregateTimeout = +argv["watch-aggregate-timeout"];
 		}
 
-		if(argv["watch-poll"]) {
+		if(typeof argv["watch-poll"] !== undefined) {
 			options.watchOptions = options.watchOptions || {};
-			if(typeof argv["watch-poll"] !== "boolean")
-				options.watchOptions.poll = +argv["watch-poll"];
-			else
+			if(argv["watch-poll"] === "true" || argv["watch-poll"] === "")
 				options.watchOptions.poll = true;
+			else if(!isNaN(argv["watch-poll"]))
+				options.watchOptions.poll = +argv["watch-poll"];
 		}
 
 		if(argv["watch-stdin"]) {
