remove chunk.isInitial constraint before moving blocks

timse · timse · commit 59ea80ff9a7c · 2017-02-22T21:35:50.000+11:00
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -339,13 +339,9 @@ Take a look at the "name"/"names" or async/children option.`);
 
 	moveExtractedChunkBlocksToTargetChunk(chunks, targetChunk) {
 		for(let chunk of chunks) {
-			// only for non initial chunks
-			// TODO: why?
-			if(!chunk.isInitial()) {
-				for(let block of chunk.blocks) {
-					block.chunks.unshift(targetChunk);
-					targetChunk.addBlock(block);
-				}
+			for(let block of chunk.blocks) {
+				block.chunks.unshift(targetChunk);
+				targetChunk.addBlock(block);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
@@ -339,13 +339,9 @@ Take a look at the "name"/"names" or async/children option.`);
`339`	`339`
`340`	`340`	`moveExtractedChunkBlocksToTargetChunk(chunks, targetChunk) {`
`341`	`341`	`for(let chunk of chunks) {`
`342`		`- // only for non initial chunks`
`343`		`- // TODO: why?`
`344`		`- if(!chunk.isInitial()) {`
`345`		`- for(let block of chunk.blocks) {`
`346`		`- block.chunks.unshift(targetChunk);`
`347`		`- targetChunk.addBlock(block);`
`348`		`- }`
	`342`	`+ for(let block of chunk.blocks) {`
	`343`	`+ block.chunks.unshift(targetChunk);`
	`344`	`+ targetChunk.addBlock(block);`
`349`	`345`	`}`
`350`	`346`	`}`
`351`	`347`	`}`