fixed bug in CommonsChunkPlugin

sokra · sokra · commit 556872b38f8b · 2015-11-20T20:24:06.000+01:00
when passing passing mixed existing and not existing names
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -41,21 +41,19 @@ CommonsChunkPlugin.prototype.apply = function(compiler) {
 			var commonChunks;
 			if(!chunkNames && (selectedChunks === false || async)) {
 				commonChunks = chunks;
-			} else if(Array.isArray(chunkNames)) {
-				commonChunks = chunkNames.map(function(chunkName) {
-					return chunks.filter(function(chunk) {
+			} else if(Array.isArray(chunkNames) || typeof chunkNames === "string") {
+				commonChunks = [].concat(chunkNames).map(function(chunkName) {
+					var chunk = chunks.filter(function(chunk) {
 						return chunk.name === chunkName;
 					})[0];
-				});
+					if(!chunk) {
+						chunk = this.addChunk(chunkName);
+						chunk.initial = chunk.entry = true;
+					}
+					return chunk;
+				}, this);
 			} else {
-				commonChunks = chunks.filter(function(chunk) {
-					return chunk.name === chunkNames;
-				});
-			}
-			if(commonChunks.length === 0) {
-				var chunk = this.addChunk(chunkNames);
-				chunk.initial = chunk.entry = true;
-				commonChunks = [chunk];
+				throw new Error("Invalid chunkNames argument");
 			}
 			commonChunks.forEach(function processCommonChunk(commonChunk, idx) {
 				var commonModulesCount = [];
